Attachment 16110 Details for Bug 14425 – Patch for 4.11 and 4.12 cherry-picked from master

[patch] Patch for 4.11 and 4.12 cherry-picked from master

bug14425-v411,v412.patch (text/plain), 1.15 KB, created by Ralph Böhme on 2020-07-03 09:10:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralph Böhme

Created: 2020-07-03 09:10:12 UTC

Size: 1.15 KB

patch

obsolete

>From e25a705a9941a1c30caa3375062bbbb81e662896 Mon Sep 17 00:00:00 2001
>From: Andrew <awalker@ixsystems.com>
>Date: Tue, 30 Jun 2020 06:54:06 -0400
>Subject: [PATCH] s3:winbind:idmap_ad - make failure to get attrnames for
> schema mode fatal
>
>Add check for failure to resolve the OID array for the schema mode into
>names.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14425
>
>Signed-off-by: Andrew <awalker@ixsystems.com>
>Reviewed-by: Stefan Metzmacher <metze@samba.org>
>(cherry picked from commit b5b801026edd3a8fd8d0ba1752e891453cf675c9)
>---
> source3/winbindd/idmap_ad.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/source3/winbindd/idmap_ad.c b/source3/winbindd/idmap_ad.c
>index a93c61f54d1..6d879cdf4d7 100644
>--- a/source3/winbindd/idmap_ad.c
>+++ b/source3/winbindd/idmap_ad.c
>@@ -162,6 +162,14 @@ static TLDAPRC get_attrnames_by_oids(struct tldap_context *ld,
> 	}
> 
> 	TALLOC_FREE(msgs);
>+	for (i=0; i<num_oids; i++) {
>+		if (names[i] == NULL) {
>+			DBG_ERR("Failed to retrieve schema name for "
>+				"oid [%s]. Schema mode is incorrect "
>+				"for this domain.\n", oids[i]);
>+			return TLDAP_FILTER_ERROR;
>+		}
>+	}
> 
> 	return TLDAP_SUCCESS;
> }
>-- 
>2.26.2
>

Flags:

metze: review+

Actions: View

Attachments on bug 14425: 16110