Attachment 16063 Details for Bug 14387 – Proposed patch for master V1

[patch] Proposed patch for master V1

bug-14387-master-v1.patch (text/plain), 1.07 KB, created by Gary Lockyer on 2020-06-22 21:00:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gary Lockyer

Created: 2020-06-22 21:00:23 UTC

Size: 1.07 KB

patch

obsolete

>From 692b7ecf31de3fb26c7f8218f4dc65ccf6119c45 Mon Sep 17 00:00:00 2001
>From: Gary Lockyer <gary@catalyst.net.nz>
>Date: Mon, 22 Jun 2020 13:42:56 +1200
>Subject: [PATCH] libcli ldap tests: remove use of zero length array
>
>libcli/ldap/tests/ldap_message_test.c defines a zero length array
>(uint8_t buf[0]), which is a GCC extension and breaks the build with
>some strict compilers like xlc.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14387
>
>Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
>---
> libcli/ldap/tests/ldap_message_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libcli/ldap/tests/ldap_message_test.c b/libcli/ldap/tests/ldap_message_test.c
>index c5aacd4bc6b..f4b49bc47bc 100644
>--- a/libcli/ldap/tests/ldap_message_test.c
>+++ b/libcli/ldap/tests/ldap_message_test.c
>@@ -115,7 +115,7 @@ static void test_empty_input(void **state)
> 	struct asn1_data *asn1;
> 	struct ldap_message *ldap_msg;
> 	NTSTATUS status;
>-	uint8_t buf[0];
>+	uint8_t *buf = NULL;
> 	size_t len = 0;
> 	struct ldap_request_limits limits = {
> 		.max_search_size = 256000,
>-- 
>2.17.1
>

Flags:

bjacke: review+
gary: ci-passed+

Actions: View

Attachments on bug 14387: 16063