Attachment 15967 Details for Bug 14374 – git-am fix for master.

[patch] git-am fix for master.

0001-s3-libsmb-A-directory-entry-from-an-SMB1-SMB2-server.patch (text/plain), 1020 bytes, created by Jeremy Allison on 2020-05-11 19:12:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2020-05-11 19:12:12 UTC

Size: 1020 bytes

patch

obsolete

>From 33b9c6c08b1a6db07b23ef9ded9864998af2efd9 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Mon, 11 May 2020 12:09:29 -0700
>Subject: [PATCH] s3: libsmb: A directory entry from an SMB1/SMB2 server must
> have a name.
>
>Add in a missing NULL pointer check in is_bad_finfo_name().
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374
>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>---
> source3/libsmb/clilist.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/source3/libsmb/clilist.c b/source3/libsmb/clilist.c
>index f868e72a239..c0e2ef5717e 100644
>--- a/source3/libsmb/clilist.c
>+++ b/source3/libsmb/clilist.c
>@@ -64,6 +64,10 @@ NTSTATUS is_bad_finfo_name(const struct cli_state *cli,
> 	NTSTATUS status = NT_STATUS_OK;
> 	bool windows_names = true;
> 
>+	if (finfo->name == NULL) {
>+		/* Can't have a missing directory name. */
>+		return NT_STATUS_INVALID_NETWORK_RESPONSE;
>+	}
> 	if (cli->requested_posix_capabilities & CIFS_UNIX_POSIX_PATHNAMES_CAP) {
> 		windows_names = false;
> 	}
>-- 
>2.20.1
>

Actions: View

Attachments on bug 14374: 15967 | 15968 | 15970 | 15972 | 15989 | 15990