The Samba-Bugzilla – Attachment 15901 Details for
Bug 14101
smbc_stat() doesn't return the correct st_mode and also the uid/gid is not filled (SMBv1)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch to remove it again for 4.12 and 4.11 and 4.10.
0001-libsmb-Don-t-try-to-find-posix-stat-info-in-SMBC_get.patch (text/plain), 2.95 KB, created by
Andreas Schneider
on 2020-04-08 09:31:59 UTC
(
hide
)
Description:
patch to remove it again for 4.12 and 4.11 and 4.10.
Filename:
MIME Type:
Creator:
Andreas Schneider
Created:
2020-04-08 09:31:59 UTC
Size:
2.95 KB
patch
obsolete
>From 686ea46cbc9538355815fe800e441d67fee6a9db Mon Sep 17 00:00:00 2001 >From: Volker Lendecke <vl@samba.org> >Date: Thu, 19 Mar 2020 11:01:41 +0100 >Subject: [PATCH] libsmb: Don't try to find posix stat info in SMBC_getatr() > >This wrongly used "frame" instead of "fname", which can never have >worked. A first attempt to fix in 51551e0d53fa6 caused a few followup >patches in an attempt to clean up the test failures 51551e0d53fa6 >introduced. They were reverted after a few discussions. So rather than >changing behaviour, just remove the code that introduced the valgrind >error again. > >Signed-off-by: Volker Lendecke <vl@samba.org> >Reviewed-by: Andreas Schneider <asn@samba.org> > >Autobuild-User(master): Jeremy Allison <jra@samba.org> >Autobuild-Date(master): Fri Mar 20 05:06:07 UTC 2020 on sn-devel-184 > >(cherry picked from commit 39c910fd9cba3caf7414274b678b9eee33d7e20b) >--- > source3/include/libsmb_internal.h | 1 - > source3/libsmb/libsmb_file.c | 20 -------------------- > source3/libsmb/libsmb_server.c | 9 --------- > 3 files changed, 30 deletions(-) > >diff --git a/source3/include/libsmb_internal.h b/source3/include/libsmb_internal.h >index 21a11c1a024..feedddd0877 100644 >--- a/source3/include/libsmb_internal.h >+++ b/source3/include/libsmb_internal.h >@@ -76,7 +76,6 @@ typedef struct DOS_ATTR_DESC { > struct _SMBCSRV { > struct cli_state *cli; > dev_t dev; >- bool try_posixinfo; > bool no_pathinfo; > bool no_pathinfo2; > bool no_pathinfo3; >diff --git a/source3/libsmb/libsmb_file.c b/source3/libsmb/libsmb_file.c >index 1577010e490..f0a16c61a83 100644 >--- a/source3/libsmb/libsmb_file.c >+++ b/source3/libsmb/libsmb_file.c >@@ -504,26 +504,6 @@ SMBC_getatr(SMBCCTX * context, > return False; > } > >- if (srv->try_posixinfo) { >- SMB_STRUCT_STAT sbuf; >- >- status = cli_posix_stat(targetcli, frame, &sbuf); >- if (NT_STATUS_IS_OK(status)) { >- setup_stat_from_stat_ex(&sbuf, path, sb); >- >- TALLOC_FREE(frame); >- return true; >- } >- if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_IMPLEMENTED) || >- NT_STATUS_EQUAL(status, NT_STATUS_INVALID_LEVEL)) { >- /* >- * Turn this off if the server doesn't >- * support it. >- */ >- srv->try_posixinfo = false; >- } >- } >- > if (!srv->no_pathinfo2) { > status = cli_qpathinfo2(targetcli, > targetpath, >diff --git a/source3/libsmb/libsmb_server.c b/source3/libsmb/libsmb_server.c >index d4f71d8c8b7..0067df48cac 100644 >--- a/source3/libsmb/libsmb_server.c >+++ b/source3/libsmb/libsmb_server.c >@@ -657,15 +657,6 @@ SMBC_server_internal(TALLOC_CTX *ctx, > ZERO_STRUCTP(srv); > DLIST_ADD(srv->cli, c); > srv->dev = (dev_t)(str_checksum(server) ^ str_checksum(share)); >- srv->try_posixinfo = false; >- /* >- * Until SMB2 POSIX is done, only >- * try POSIX stat on SMB1 with POSIX capabilities. >- */ >- if ((smbXcli_conn_protocol(c->conn) < PROTOCOL_SMB2_02) && >- (smb1cli_conn_capabilities(c->conn) & CAP_UNIX)) { >- srv->try_posixinfo = true; >- } > srv->no_pathinfo = False; > srv->no_pathinfo2 = False; > srv->no_pathinfo3 = False; >-- >2.26.0 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=15901">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Flags:
ab
:
review+
jra
:
review+
Actions:
View
Attachments on
bug 14101
:
15712
|
15714
|
15839
|
15840
|
15841
| 15901