Attachment 15759 Details for Bug 14257 – patch for 4.12 and 4.11

[patch] patch for 4.12 and 4.11

0001-s4-torture-Skip-the-deltest20-as-user-root.patch (text/plain), 1.19 KB, created by Andreas Schneider on 2020-01-31 09:28:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2020-01-31 09:28:09 UTC

Size: 1.19 KB

patch

obsolete

>From ee29cacb7e8849ebe9815c16b3ff625f3f1a50fd Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Thu, 30 Jan 2020 16:18:25 +0100
>Subject: [PATCH] s4:torture: Skip the deltest20 as user root
>
>The test is meant to be run as a user and not root.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14257
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Ralph Boehme <slow@samba.org>
>
>Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
>Autobuild-Date(master): Thu Jan 30 16:54:33 UTC 2020 on sn-devel-184
>
>(cherry picked from commit 677bc1b18420e717154dc73f632044239ac3ff9e)
>---
> source4/torture/basic/delete.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/source4/torture/basic/delete.c b/source4/torture/basic/delete.c
>index a8c4e3fa3f1..d14d5a55746 100644
>--- a/source4/torture/basic/delete.c
>+++ b/source4/torture/basic/delete.c
>@@ -1865,6 +1865,10 @@ static bool deltest20(struct torture_context *tctx, struct smbcli_state *cli1, s
> 	NTSTATUS status;
> 	int ret;
> 
>+	if (geteuid() == 0) {
>+		torture_skip(tctx, "This test doesn't work as user root.");
>+	}
>+
> 	del_clean_area(cli1, cli2);
> 
> 	/* Test 20 -- non-empty directory hardest to get right... */
>-- 
>2.25.0
>

Flags:

slow: review+

Actions: View

Attachments on bug 14257: 15756 | 15759