Attachment 15753 Details for Bug 14251 – patch for 4.11

[patch] patch for 4.11

0001-smbd-Fix-the-build-with-clang.patch (text/plain), 1.01 KB, created by Andreas Schneider on 2020-01-24 15:55:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2020-01-24 15:55:48 UTC

Size: 1.01 KB

patch

obsolete

>From 7de67a994e84c2fadccb48c2448f2cba529a57fd Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Wed, 31 Jul 2019 10:42:24 +0200
>Subject: [PATCH] smbd: Fix the build with clang
>
>clang correctly complains that "close_fsp" is used uninitialized if
>"get_posix_fsp" fails and we end up in "goto out;".
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14251
>
>Signed-off-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>(cherry picked from commit a8a1ca3f83dce6d725392989cbc97271cbf52f4a)
>---
> source3/smbd/trans2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
>index b0616f15ade..8164c8fd213 100644
>--- a/source3/smbd/trans2.c
>+++ b/source3/smbd/trans2.c
>@@ -4848,7 +4848,7 @@ static NTSTATUS smb_query_posix_acl(connection_struct *conn,
> 	unsigned int size_needed = 0;
> 	NTSTATUS status;
> 	bool ok;
>-	bool close_fsp;
>+	bool close_fsp = false;
> 
> 	/*
> 	 * Ensure we always operate on a file descriptor, not just
>-- 
>2.24.1
>

Flags:

vl: review+
gd: review+

Actions: View

Attachments on bug 14251: 15753