Attachment 15722 Details for Bug 14231 – Adding text=True to popen call

[patch] Adding text=True to popen call

file_14231.txt (text/plain), 1.09 KB, created by Torsten Fohrer on 2020-01-07 11:53:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Torsten Fohrer

Created: 2020-01-07 11:53:23 UTC

Size: 1.09 KB

patch

obsolete

>From 452894fc0ffb97e4fecd0913d36200507f041fe4 Mon Sep 17 00:00:00 2001
>From: Torsten Fohrer <torsten.fohrer@sbe.de>
>Date: Tue, 7 Jan 2020 12:48:25 +0100
>Subject: [PATCH] Fixes ERROR(<class 'TypeError'>): uncaught exception -
> memoryview: a bytes-like object is required, not 'str'
>
>when using samba user password synchronization hook with python 3.7/3.8.
>
>Signed-off-by: Torsten Fohrer <torsten.fohrer@sbe.de>
>---
> python/samba/netcmd/user.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/python/samba/netcmd/user.py b/python/samba/netcmd/user.py
>index 86a7a45b24e..f0dff0f97e2 100644
>--- a/python/samba/netcmd/user.py
>+++ b/python/samba/netcmd/user.py
>@@ -1952,7 +1952,7 @@ samba-tool user syncpasswords --terminate \\
>             sync_command_p = Popen(self.sync_command,
>                                    stdin=PIPE,
>                                    stdout=PIPE,
>-                                   stderr=STDOUT)
>+                                   stderr=STDOUT, text=True)
> 
>             res = sync_command_p.poll()
>             assert res is None
>-- 
>2.24.1

Actions: View

Attachments on bug 14231: 15722