Attachment 15666 Details for Bug 14209 – patch for 4.11

[patch] patch for 4.11

bug-14209-for-4-11.patch (text/plain), 1.20 KB, created by Douglas Bagnall on 2019-12-04 21:54:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Douglas Bagnall

Created: 2019-12-04 21:54:00 UTC

Size: 1.20 KB

patch

obsolete

>From c8c050778a70ba66f5c3c07dab1d0cfaff6156e3 Mon Sep 17 00:00:00 2001
>From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
>Date: Tue, 3 Dec 2019 11:17:26 +1300
>Subject: [PATCH] pygpo: use correct method flags
>
>The METH_KEYWORDS argument must always be combined with METH_VARARGS.
>
>In Python up to 3.7 this was checked at runtime, and as we had no callers to
>get_unix_path() in Python we never noticed. In Python 3.8 it is checked at
>import time, and everyone notices even if they aren't directly using GPOs.
>
>Found and reported by Val Kulkov.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14209
>Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
>Reviewed-by: Andrew Bartlett <abartlet@samba.org>
>(cherry picked from commit 12cccf3447333dfd4f5e437cd57ca5ec68724fdd)
>---
> libgpo/pygpo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c
>index 581d20e0649..97bbb3ec528 100644
>--- a/libgpo/pygpo.c
>+++ b/libgpo/pygpo.c
>@@ -118,7 +118,7 @@ out:
> static PyMethodDef GPO_methods[] = {
> 	{"get_unix_path", PY_DISCARD_FUNC_SIG(PyCFunction,
> 					      py_gpo_get_unix_path),
>-		METH_KEYWORDS,
>+		METH_VARARGS | METH_KEYWORDS,
> 		NULL },
> 	{NULL}
> };
>-- 
>2.20.1
>

Flags:

abartlet: review+

Actions: View

Attachments on bug 14209: 15660 | 15665 | 15666 | 15673 | 15683 | 15707 | 15709 | 15710 | 15711