The Samba-Bugzilla – Attachment 15660 Details for
Bug 14209
samba-tool fails with uncaught exception - bad call flags on Python 3.8
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch in the missing METH_VARARGS
0001-pygpo-use-correct-method-flags.patch (text/plain), 1.08 KB, created by
Douglas Bagnall
on 2019-12-02 22:20:48 UTC
(
hide
)
Description:
patch in the missing METH_VARARGS
Filename:
MIME Type:
Creator:
Douglas Bagnall
Created:
2019-12-02 22:20:48 UTC
Size:
1.08 KB
patch
obsolete
>From 1850dfd2b183a171fbdaae1543e1fe7f445d4c25 Mon Sep 17 00:00:00 2001 >From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> >Date: Tue, 3 Dec 2019 11:17:26 +1300 >Subject: [PATCH] pygpo: use correct method flags > >The METH_KEYWORDS argument must always be combined with METH_VARARGS. > >In Python up to 3.7 this was checked at runtime, and as we had no callers to >get_unix_path() in Python we never noticed. In Python 3.8 it is checked at >import time, and everyone notices even if they aren't directly using GPOs. > >Found and reported by Val Kulkov. > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=14209 >Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> >--- > libgpo/pygpo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c >index 581d20e0649..97bbb3ec528 100644 >--- a/libgpo/pygpo.c >+++ b/libgpo/pygpo.c >@@ -118,7 +118,7 @@ out: > static PyMethodDef GPO_methods[] = { > {"get_unix_path", PY_DISCARD_FUNC_SIG(PyCFunction, > py_gpo_get_unix_path), >- METH_KEYWORDS, >+ METH_VARARGS | METH_KEYWORDS, > NULL }, > {NULL} > }; >-- >2.20.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 14209
: 15660 |
15665
|
15666
|
15673
|
15683
|
15707
|
15709
|
15710
|
15711