The Samba-Bugzilla – Attachment 15602 Details for
Bug 13874
ndr_pull_string_array() looping in drsblobs decode_Packages()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
wip patch for master
nulltermfix.patch (text/plain), 797 bytes, created by
Andrew Bartlett
on 2019-11-06 23:18:37 UTC
(
hide
)
Description:
wip patch for master
Filename:
MIME Type:
Creator:
Andrew Bartlett
Created:
2019-11-06 23:18:37 UTC
Size:
797 bytes
patch
obsolete
>diff --git a/librpc/ndr/ndr_string.c b/librpc/ndr/ndr_string.c >index cc3508616bb..4882b778a17 100644 >--- a/librpc/ndr/ndr_string.c >+++ b/librpc/ndr/ndr_string.c >@@ -118,9 +118,16 @@ _PUBLIC_ enum ndr_err_code ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, > break; > > case LIBNDR_FLAG_STR_NULLTERM: >+ /* >+ * We ensure that conv_str_len cannot return 0 by >+ * requring that there be enough bytes for at least >+ * the NULL terminator >+ */ > if (byte_mul == 1) { >+ NDR_PULL_NEED_BYTES(ndr, 1); > conv_src_len = ascii_len_n((const char *)(ndr->data+ndr->offset), ndr->data_size - ndr->offset); > } else { >+ NDR_PULL_NEED_BYTES(ndr, 2); > conv_src_len = utf16_len_n(ndr->data+ndr->offset, ndr->data_size - ndr->offset); > } > byte_mul = 1; /* the length is now absolute */
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=15602">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 13874
: 15602 |
15659
|
15661