The Samba-Bugzilla – Attachment 15472 Details for
Bug 14128
username/password authentication doesn't work with CUPS and smbspool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Updated patch with additional comments
0001-s3-client-Use-DEVICE_URI-instead-of-argv-0-for-Devic.patch (text/plain), 1.29 KB, created by
Bryan Mason
on 2019-09-17 16:16:14 UTC
(
hide
)
Description:
Updated patch with additional comments
Filename:
MIME Type:
Creator:
Bryan Mason
Created:
2019-09-17 16:16:14 UTC
Size:
1.29 KB
patch
obsolete
>From 9ee750bfd3e505e8500376886a37a4e8b840c2cf Mon Sep 17 00:00:00 2001 >From: Bryan Mason <bmason@redhat.com> >Date: Mon, 16 Sep 2019 12:35:06 -0700 >Subject: [PATCH] s3:client:Use DEVICE_URI, instead of argv[0],for Device URI > >CUPS sanitizes argv[0] by removing username/password, so use >DEVICE_URI environment variable first. > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=14128 >Signed-off-by: Bryan Mason <bmason@redhat.com> >--- > source3/client/smbspool.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > >diff --git a/source3/client/smbspool.c b/source3/client/smbspool.c >index ad988eb0df9..36f7f67ca94 100644 >--- a/source3/client/smbspool.c >+++ b/source3/client/smbspool.c >@@ -256,13 +256,15 @@ main(int argc, /* I - Number of command-line arguments */ > > /* > * Find the URI ... >- */ >- if (dev_uri == NULL) { >- env = getenv("DEVICE_URI"); >- if (env != NULL && env[0] != '\0') { >- dev_uri = env; >- } >- } >+ * >+ * The URI in argv[0] is sanitized to remove username/password, so >+ * use DEVICE_URI if available. Otherwise keep the URI already >+ * discovered in argv. >+ */ >+ env = getenv("DEVICE_URI"); >+ if (env != NULL && env[0] != '\0') { >+ dev_uri = env; >+ } > > if (dev_uri == NULL) { > fprintf(stderr, >-- >2.21.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
asn
:
review+
gd
:
review+
ab
:
review+
Actions:
View
Attachments on
bug 14128
:
15470
| 15472 |
15473
|
15474