Attachment 15410 Details for Bug 14086 – Patch for 4.11

[patch] Patch for 4.11

BZ14086-v4-11.patch (text/plain), 1.11 KB, created by Martin Schwenke on 2019-08-22 04:15:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Schwenke

Created: 2019-08-22 04:15:43 UTC

Size: 1.11 KB

patch

obsolete

>From 4d7c54e0a204b4b2b16b2e402fd30d54402adf31 Mon Sep 17 00:00:00 2001
>From: Martin Schwenke <martin@meltin.net>
>Date: Mon, 12 Aug 2019 16:11:13 +1000
>Subject: [PATCH] ctdb-tools: Drop 'o' option from getopts command
>
>Commit 90de5e0594b9180226b9a13293afe31f18576b3d remove the processing
>for this option but forgot to remove it from the getopts command.
>
>Versions of ShellCheck >= 0.4.7 warn on this, so it is worth fixing.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14086
>RN: Fix onnode test failure with ShellCheck >= 0.4.7
>Signed-off-by: Martin Schwenke <martin@meltin.net>
>Reviewed-by: Amitay Isaacs <amitay@gmail.com>
>(cherry picked from commit 758962a0d435fa595e3917b860a8fd266d122550)
>---
> ctdb/tools/onnode | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/ctdb/tools/onnode b/ctdb/tools/onnode
>index e143ba2d4d4..d6595fff4aa 100755
>--- a/ctdb/tools/onnode
>+++ b/ctdb/tools/onnode
>@@ -72,7 +72,7 @@ parse_options ()
> {
> 	local opt
> 
>-	while getopts "cf:hno:pqvPi?" opt ; do
>+	while getopts "cf:hnpqvPi?" opt ; do
> 		case "$opt" in
> 		c) current=true ;;
> 		f) ctdb_nodes_file="$OPTARG" ;;
>-- 
>2.23.0.rc1
>

Flags:

amitay: review+

Actions: View

Attachments on bug 14086: 15410