Attachment 15078 Details for Bug 13892 – Patch for v4-10-test

[patch] Patch for v4-10-test

tmp410.diff.txt (text/plain), 1.08 KB, created by Stefan Metzmacher on 2019-04-17 21:12:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2019-04-17 21:12:09 UTC

Size: 1.08 KB

patch

obsolete

>From d1e31db4f634662b3bcd3bdb2b937a14335a14b1 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Tue, 9 Apr 2019 12:47:13 +0200
>Subject: [PATCH] lib: Initialize getline() arguments
>
>Keep "len" valid across the loop iterations for getline to consume
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=13892
>
>Signed-off-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Stefan Metzmacher <metze@samba.org>
>(cherry picked from commit c0b2272a7d15d266ce64c86cf6a313b5b0fb67fd)
>---
> libcli/dns/resolvconf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libcli/dns/resolvconf.c b/libcli/dns/resolvconf.c
>index 90d4e6a74b69..ee2eec6573b3 100644
>--- a/libcli/dns/resolvconf.c
>+++ b/libcli/dns/resolvconf.c
>@@ -30,6 +30,7 @@ int parse_resolvconf_fp(
> 	size_t *pnum_nameservers)
> {
> 	char *line = NULL;
>+	size_t len = 0;
> 	char **nameservers = NULL;
> 	size_t num_nameservers = 0;
> 	int ret = 0;
>@@ -38,7 +39,6 @@ int parse_resolvconf_fp(
> 		char *saveptr, *option, *ns;
> 		char **tmp;
> 		ssize_t n;
>-		size_t len;
> 
> 		n = getline(&line, &len, fp);
> 		if (n < 0) {
>-- 
>2.17.1
>

Flags:

vl: review+

Actions: View

Attachments on bug 13892: 15053 | 15054 | 15078