Attachment 14972 Details for Bug 13841 – s4_dlz_make_b9_has_soa_check_dc_at_node.patch

[patch] s4_dlz_make_b9_has_soa_check_dc_at_node.patch

s4_dlz_make_b9_has_soa_check_dc_at_node.patch (text/plain), 1.30 KB, created by Michael Saxl on 2019-03-21 17:25:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Saxl

Created: 2019-03-21 17:25:43 UTC

Size: 1.30 KB

patch

obsolete

>From 34456fab62fedc6a938d189c7485f40899b3fbb6 Mon Sep 17 00:00:00 2001
>From: Michael Saxl <mike@mwsys.mine.bz>
>Date: Tue, 21 Mar 2019 18:22:38 +0100
>Subject: [PATCH] s4:dlz make b9_has_soa check dc=@ node
>
>the zone node does not hold the dnsRecord values, so for the zone level
>the node dc=@,dc=zonename has to be queried
>
>regression introduced with 28e2a518ff32, BUG: https://bugzilla.samba.org/show_bug.cgi?id=13466
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=13841
>
>Signed-off-by: Michael Saxl <mike@mwsys.mine.bz>
>
>---
> source4/dns_server/dlz_bind9.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>diff --git a/source4/dns_server/dlz_bind9.c b/source4/dns_server/dlz_bind9.c
>index 82c72111a00..b46dec6cb35 100644
>--- a/source4/dns_server/dlz_bind9.c
>+++ b/source4/dns_server/dlz_bind9.c
>@@ -1276,6 +1276,17 @@ static bool b9_has_soa(struct dlz_bind9_data *state, struct ldb_dn *dn, const ch
> 		return false;
> 	}
> 
>+	/*
>+	 * The SOA record is alwas stored under DC=@,DC=zonename
>+	 * This can probably be removed when dns_common_lookup makes a fallback
>+	 * lookup on @ pseudo record
>+	 */
>+
>+	if (!ldb_dn_add_child_fmt(dn,"DC=@")) {
>+		talloc_free(tmp_ctx);
>+		return false;
>+	}
>+
> 	werr = dns_common_lookup(state->samdb, tmp_ctx, dn,
> 				 &records, &num_records, NULL);
> 	if (!W_ERROR_IS_OK(werr)) {
>-- 
>2.19.1
>

Actions: View

Attachments on bug 13841: 14942 | 14950 | 14967 | 14969 | 14972 | 14973 | 14992