Attachment 14919 Details for Bug 13823 – patch for 4.10, 4.9 and 4.8

[patch] patch for 4.10, 4.9 and 4.8

v4-10-test.patch (text/plain), 1.12 KB, created by Andreas Schneider on 2019-03-12 08:09:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2019-03-12 08:09:20 UTC

Size: 1.12 KB

patch

obsolete

>From 0c581cd4a086ead58aff57c1f40238a88208ee85 Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Thu, 7 Mar 2019 12:31:42 +0100
>Subject: [PATCH] lib:util: Move debug message for mkdir failing to log level 1
>
>If you connnect to a host with smbclient this gets always printed.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=13823
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Andrew Bartlett <abartlet@samba.org>
>
>(cherry picked from commit c71334ec0c92e791022a9b7c900aa0dd649226c2)
>---
> lib/util/util.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/lib/util/util.c b/lib/util/util.c
>index f52f69c6ef0..dc1772c839e 100644
>--- a/lib/util/util.c
>+++ b/lib/util/util.c
>@@ -200,9 +200,9 @@ _PUBLIC_ bool directory_create_or_exist(const char *dname,
> 	old_umask = umask(0);
> 	ret = mkdir(dname, dir_perms);
> 	if (ret == -1 && errno != EEXIST) {
>-		DEBUG(0, ("mkdir failed on directory "
>-			  "%s: %s\n", dname,
>-			  strerror(errno)));
>+		DBG_WARNING("mkdir failed on directory %s: %s\n",
>+			    dname,
>+			    strerror(errno));
> 		umask(old_umask);
> 		return false;
> 	}
>-- 
>2.21.0
>

Flags:

ab: review+

Actions: View

Attachments on bug 13823: 14919