Attachment 14849 Details for Bug 13788 – patch fixing incorrect use of split(' ')

[patch] patch fixing incorrect use of split(' ')

patch_bugzilla_13788.patch (text/plain), 1.40 KB, created by Denis Cardon on 2019-02-15 10:29:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Denis Cardon

Created: 2019-02-15 10:29:35 UTC

Size: 1.40 KB

patch

obsolete

> python/samba/netcmd/dns.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/python/samba/netcmd/dns.py b/python/samba/netcmd/dns.py
>index b7459a71acd..2ac75453108 100644
>--- a/python/samba/netcmd/dns.py
>+++ b/python/samba/netcmd/dns.py
>@@ -416,14 +416,14 @@ def data_to_dns_record(record_type, data):
>     elif record_type == dnsp.DNS_TYPE_NS:
>         rec = NSRecord(data)
>     elif record_type == dnsp.DNS_TYPE_MX:
>-        tmp = data.split(' ')
>+        tmp = data.split()
>         if len(tmp) != 2:
>             raise CommandError('Data requires 2 elements - mail_server, preference')
>         mail_server = tmp[0]
>         preference = int(tmp[1])
>         rec = MXRecord(mail_server, preference)
>     elif record_type == dnsp.DNS_TYPE_SRV:
>-        tmp = data.split(' ')
>+        tmp = data.split()
>         if len(tmp) != 4:
>             raise CommandError('Data requires 4 elements - server, port, priority, weight')
>         server = tmp[0]
>@@ -432,7 +432,7 @@ def data_to_dns_record(record_type, data):
>         weight = int(tmp[3])
>         rec = SRVRecord(server, port, priority=priority, weight=weight)
>     elif record_type == dnsp.DNS_TYPE_SOA:
>-        tmp = data.split(' ')
>+        tmp = data.split()
>         if len(tmp) != 7:
>             raise CommandError('Data requires 7 elements - nameserver, email, serial, '
>                                'refresh, retry, expire, minimumttl')

Actions: View

Attachments on bug 13788: 14849