The Samba-Bugzilla – Attachment 14804 Details for
Bug 13766
printcap still processed with "load printers" disabled in smb.conf
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patchset, currently undergoing testing
check_lp_load_printers.patchset (text/plain), 4.26 KB, created by
David Disseldorp
on 2019-01-29 01:03:44 UTC
(
hide
)
Description:
proposed patchset, currently undergoing testing
Filename:
MIME Type:
Creator:
David Disseldorp
Created:
2019-01-29 01:03:44 UTC
Size:
4.26 KB
patch
obsolete
>From bbbfa56d1a620a7e4d5611531f40faeb09736291 Mon Sep 17 00:00:00 2001 >From: David Disseldorp <ddiss@samba.org> >Date: Tue, 29 Jan 2019 01:50:15 +0100 >Subject: [PATCH 1/2] printing: drop pcap_cache_loaded() guard around > load_printers() > >Add the pcap_cache_loaded() check to load_printers() and return early >if it returns false. This simplifies callers in preparation for checking >lp_load_printers() in the printcap cache update code-path. > >Bug: https://bugzilla.samba.org/show_bug.cgi?id=13766 > >Signed-off-by: David Disseldorp <ddiss@samba.org> >--- > source3/printing/load.c | 4 +++- > source3/printing/queue_process.c | 4 +--- > source3/printing/spoolssd.c | 8 ++------ > 3 files changed, 6 insertions(+), 10 deletions(-) > >diff --git a/source3/printing/load.c b/source3/printing/load.c >index 51495f970db..7e25d5a91c7 100644 >--- a/source3/printing/load.c >+++ b/source3/printing/load.c >@@ -64,7 +64,9 @@ load automatic printer services from pre-populated pcap cache > ***************************************************************************/ > void load_printers(void) > { >- SMB_ASSERT(pcap_cache_loaded(NULL)); >+ if (!pcap_cache_loaded(NULL)) { >+ return; >+ } > > add_auto_printers(); > >diff --git a/source3/printing/queue_process.c b/source3/printing/queue_process.c >index 1d60f259a86..197bde01086 100644 >--- a/source3/printing/queue_process.c >+++ b/source3/printing/queue_process.c >@@ -483,9 +483,7 @@ void printing_subsystem_update(struct tevent_context *ev_ctx, > bool force) > { > if (background_lpq_updater_pid != -1) { >- if (pcap_cache_loaded(NULL)) { >- load_printers(); >- } >+ load_printers(); > if (force) { > /* Send a sighup to the background process. > * this will force it to reload printers */ >diff --git a/source3/printing/spoolssd.c b/source3/printing/spoolssd.c >index c029f1a11d5..1809679ebca 100644 >--- a/source3/printing/spoolssd.c >+++ b/source3/printing/spoolssd.c >@@ -288,9 +288,7 @@ static bool spoolss_child_init(struct tevent_context *ev_ctx, > * If so then we probably missed a message and should load_printers() > * ourselves. If pcap has not been loaded yet, then ignore, we will get > * a message as soon as the bq process completes the reload. */ >- if (pcap_cache_loaded(NULL)) { >- load_printers(); >- } >+ load_printers(); > > /* try to reinit rpc queues */ > spoolss_cb.init = spoolss_init_cb; >@@ -699,9 +697,7 @@ pid_t start_spoolssd(struct tevent_context *ev_ctx, > * If pcap has not been loaded yet, then ignore, as we will reload on > * client enumeration anyway. > */ >- if (pcap_cache_loaded(NULL)) { >- load_printers(); >- } >+ load_printers(); > > mem_ctx = talloc_new(NULL); > if (mem_ctx == NULL) { >-- >2.13.7 > > >From d41c494487e3deacd9444906922e0461e7267bb6 Mon Sep 17 00:00:00 2001 >From: David Disseldorp <ddiss@samba.org> >Date: Tue, 29 Jan 2019 01:55:04 +0100 >Subject: [PATCH 2/2] printing: check lp_load_printers() prior to pcap cache > update > >Avoid explicit and housekeeping timer triggered printcap cache updates >if lp_load_printers() is disabled. > >Bug: https://bugzilla.samba.org/show_bug.cgi?id=13766 > >Signed-off-by: David Disseldorp <ddiss@samba.org> >--- > source3/printing/pcap.c | 5 +++++ > source3/printing/queue_process.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > >diff --git a/source3/printing/pcap.c b/source3/printing/pcap.c >index 726111816d6..d771cd9dfeb 100644 >--- a/source3/printing/pcap.c >+++ b/source3/printing/pcap.c >@@ -139,6 +139,11 @@ void pcap_cache_reload(struct tevent_context *ev, > > DEBUG(3, ("reloading printcap cache\n")); > >+ if (!lp_load_printers()) { >+ DBG_NOTICE("skipping reload - load printers disabled\n"); >+ return; >+ } >+ > /* only go looking if no printcap name supplied */ > if (pcap_name == NULL || *pcap_name == 0) { > DEBUG(0, ("No printcap file name configured!\n")); >diff --git a/source3/printing/queue_process.c b/source3/printing/queue_process.c >index 197bde01086..7ac609a318a 100644 >--- a/source3/printing/queue_process.c >+++ b/source3/printing/queue_process.c >@@ -172,7 +172,7 @@ static bool printing_subsystem_queue_tasks(struct bq_state *state) > /* cancel any existing housekeeping event */ > TALLOC_FREE(state->housekeep); > >- if (housekeeping_period == 0) { >+ if ((housekeeping_period == 0) || !lp_load_printers()) { > DEBUG(4, ("background print queue housekeeping disabled\n")); > return true; > } >-- >2.13.7 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 13766
: 14804 |
14829
|
14830