The Samba-Bugzilla – Attachment 14771 Details for
Bug 13743
Logical "off by one" issue in loop counts up to IOV_MAX
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
IOV_MAX "off by one" issue fix in lib/tsocket/tsocket.c
IOV_MAX.patch (text/plain), 853 bytes, created by
Jura Sasek
on 2019-01-14 23:32:25 UTC
(
hide
)
Description:
IOV_MAX "off by one" issue fix in lib/tsocket/tsocket.c
Filename:
MIME Type:
Creator:
Jura Sasek
Created:
2019-01-14 23:32:25 UTC
Size:
853 bytes
patch
obsolete
>Logical "off by one" issue in loop counts up to IOV_MAX > >IOV_MAX is set to 16 on Solaris but Samba passes up to 17 IO-vectors >to writev/readv > >Also has been found "difference" between maximal value of "iovcnt" >(3rd arg. of writev/readv) in: > Solaris manpage writev(2) >and > POSIX standard: > http://pubs.opengroup.org/onlinepubs/9699919799/functions/writev.html > >--- a/lib/tsocket/tsocket.c 2019-01-02 12:59:28.320172791 +0000 >+++ b/lib/tsocket/tsocket.c 2019-01-02 13:12:26.155345793 +0000 >@@ -539,7 +539,7 @@ > > /* first check if the input is ok */ > #ifdef IOV_MAX >- if (count > IOV_MAX) { >+ if (count >= IOV_MAX) { > tevent_req_error(req, EMSGSIZE); > goto post; > } >@@ -661,7 +661,7 @@ > > /* first check if the input is ok */ > #ifdef IOV_MAX >- if (count > IOV_MAX) { >+ if (count >= IOV_MAX) { > tevent_req_error(req, EMSGSIZE); > goto post; > }
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=14771">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 13743
: 14771