Attachment 14543 Details for Bug 13665 – fix

[patch] fix

0001-lib-socket-If-returning-early-set-ifaces.patch (text/plain), 1.08 KB, created by David Mulder on 2018-10-25 18:53:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Mulder

Created: 2018-10-25 18:53:49 UTC

Size: 1.08 KB

patch

obsolete

>From c3c376ebba8e3cb9c8a0c56c3021bf5d7bd49322 Mon Sep 17 00:00:00 2001
>From: David Mulder <dmulder@suse.com>
>Date: Wed, 24 Oct 2018 10:55:02 -0600
>Subject: [PATCH] lib:socket: If returning early, set ifaces
>
>Prevents a segfault in load_interfaces() when total interfaces == 1.
>Fixes regression caused by da68a1b2f417ec82ea4ed3e7a4d867cef8ca8f93.
>
>Signed-off-by: David Mulder <dmulder@suse.com>
>---
> lib/socket/interfaces.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/lib/socket/interfaces.c b/lib/socket/interfaces.c
>index 168bff501c2..ac26b97c248 100644
>--- a/lib/socket/interfaces.c
>+++ b/lib/socket/interfaces.c
>@@ -363,12 +363,13 @@ static int iface_comp(struct iface_struct *i1, struct iface_struct *i2)
>    above */
> int get_interfaces(TALLOC_CTX *mem_ctx, struct iface_struct **pifaces)
> {
>-	struct iface_struct *ifaces;
>+	struct iface_struct *ifaces = NULL;
> 	int total, i, j;
> 
> 	total = _get_interfaces(mem_ctx, &ifaces);
> 	/* If we have an error, no interface or just one we can leave */
> 	if (total <= 1) {
>+		*pifaces = ifaces;
> 		return total;
> 	}
> 
>-- 
>2.16.4
>

Actions: View

Attachments on bug 13665: 14543 | 14554