Attachment 1447 Details for Bug 3095 – Patch for HEAD.

[patch] Patch for HEAD.

look (text/plain), 1.47 KB, created by Jeremy Allison on 2005-09-15 10:26:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2005-09-15 10:26:52 UTC

Size: 1.47 KB

patch

obsolete

>Index: rpc_client/cli_netlogon.c
>===================================================================
>--- rpc_client/cli_netlogon.c	(revision 10240)
>+++ rpc_client/cli_netlogon.c	(working copy)
>@@ -611,8 +611,8 @@
> 
> 	result = r.status;
> 
>-	if (!NT_STATUS_IS_ERR(result)) {
>-		/* Check returned credentials. */
>+	if (r.buffer_creds) {
>+		/* Check returned credentials if present. */
> 		if (!creds_client_check(cli->dc, &r.srv_creds.challenge)) {
> 			DEBUG(0,("rpccli_netlogon_sam_logon: credentials chain check failed\n"));
> 			return NT_STATUS_ACCESS_DENIED;
>@@ -724,8 +724,8 @@
> 
> 	result = r.status;
> 
>-	if (!NT_STATUS_IS_ERR(result)) {
>-		/* Check returned credentials. */
>+	if (r.buffer_creds) {
>+		/* Check returned credentials if present. */
> 		if (!creds_client_check(cli->dc, &r.srv_creds.challenge)) {
> 			DEBUG(0,("rpccli_netlogon_sam_network_logon: credentials chain check failed\n"));
> 			return NT_STATUS_ACCESS_DENIED;
>@@ -774,12 +774,10 @@
> 		DEBUG(0,("cli_net_srv_pwset: %s\n", nt_errstr(result)));
> 	}
> 
>-	if (!NT_STATUS_IS_ERR(result)) {
>-		/* Check returned credentials. */
>-		if (!creds_client_check(cli->dc, &r.srv_cred.challenge)) {
>-			DEBUG(0,("rpccli_net_srv_pwset: credentials chain check failed\n"));
>-			return NT_STATUS_ACCESS_DENIED;
>-		}
>+	/* Always check returned credentials. */
>+	if (!creds_client_check(cli->dc, &r.srv_cred.challenge)) {
>+		DEBUG(0,("rpccli_net_srv_pwset: credentials chain check failed\n"));
>+		return NT_STATUS_ACCESS_DENIED;
> 	}
> 
> 	return result;

Actions: View

Attachments on bug 3095: 1443 | 1444 | 1446 | 1447 | 1451