The Samba-Bugzilla – Attachment 14176 Details for
Bug 13419
libsmbclient returns a hard coded error of ETIMEDOUT on server connection failure.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
git-am fix for 4.8.next, 4.7.next.
0001-s3-libsmbclient-Fix-hard-coded-connection-error-retu.patch (text/plain), 1.32 KB, created by
Jeremy Allison
on 2018-05-03 19:48:53 UTC
(
hide
)
Description:
git-am fix for 4.8.next, 4.7.next.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2018-05-03 19:48:53 UTC
Size:
1.32 KB
patch
obsolete
>From 479446c904182dcf5ca686a5fc7ba24e6742fca7 Mon Sep 17 00:00:00 2001 >From: Jeremy Allison <jra@samba.org> >Date: Wed, 2 May 2018 11:19:31 -0700 >Subject: [PATCH] s3: libsmbclient: Fix hard-coded connection error return of > ETIMEDOUT. > >We shouldn't hard-code the connection error as ETIMEDOUT when >we have a perfectly good NT_STATUS to map from. > >Found by the ChromeOS guys trying to connect an SMB2-only client >to an SMB1-only supporting server. > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=13419 > >Signed-off-by: Jeremy Allison <jra@samba.org> >Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE> > >Autobuild-User(master): Jeremy Allison <jra@samba.org> >Autobuild-Date(master): Thu May 3 02:42:20 CEST 2018 on sn-devel-144 > >(cherry picked from commit 795ec751ac5f6e58966385bec25063c4af4f185d) >--- > source3/libsmb/libsmb_server.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/source3/libsmb/libsmb_server.c b/source3/libsmb/libsmb_server.c >index e6067be2013..67dfcf72327 100644 >--- a/source3/libsmb/libsmb_server.c >+++ b/source3/libsmb/libsmb_server.c >@@ -500,7 +500,7 @@ SMBC_server_internal(TALLOC_CTX *ctx, > lp_client_max_protocol()); > if (!NT_STATUS_IS_OK(status)) { > cli_shutdown(c); >- errno = ETIMEDOUT; >+ errno = map_errno_from_nt_status(status); > return NULL; > } > >-- >2.17.0.441.gb46fe60e1d-goog >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
vl
:
review+
ab
:
review+
Actions:
View
Attachments on
bug 13419
: 14176