Attachment 14170 Details for Bug 13400 – Patch for v4-7-test

[patch] Patch for v4-7-test

tmp47.diff.txt (text/plain), 1.06 KB, created by Stefan Metzmacher on 2018-05-02 08:40:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2018-05-02 08:40:44 UTC

Size: 1.06 KB

patch

obsolete

>From aa22f50538cd45df480896f2beefc752fd312778 Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Tue, 24 Apr 2018 10:59:05 +0200
>Subject: [PATCH] nsswitch: fix memory leak in winbind_open_pipe_sock() when
> the privileged pipe is not accessable.
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=13400
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>(cherry picked from commit ffe970007bf934955f72ec2d73bf8f94a2b796eb)
>---
> nsswitch/wb_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/nsswitch/wb_common.c b/nsswitch/wb_common.c
>index 262181a..336092b 100644
>--- a/nsswitch/wb_common.c
>+++ b/nsswitch/wb_common.c
>@@ -420,14 +420,14 @@ static int winbind_open_pipe_sock(struct winbindd_context *ctx,
> 			ctx->winbindd_fd = fd;
> 			ctx->is_privileged = 1;
> 		}
>+
>+		SAFE_FREE(response.extra_data.data);
> 	}
> 
> 	if ((need_priv != 0) && (ctx->is_privileged == 0)) {
> 		return -1;
> 	}
> 
>-	SAFE_FREE(response.extra_data.data);
>-
> 	return ctx->winbindd_fd;
> #else
> 	return -1;
>-- 
>1.9.1
>

Flags:

vl: review+

Actions: View

Attachments on bug 13400: 14169 | 14170