Attachment 14160 Details for Bug 13395 – patch to fix the error code

[patch] patch to fix the error code

0001-printing-return-the-same-error-code-as-windows-does-.patch (text/plain), 1.07 KB, created by Björn Jacke on 2018-04-20 11:09:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Björn Jacke

Created: 2018-04-20 11:09:29 UTC

Size: 1.07 KB

patch

obsolete

>From b4f1b45bcefbfe52a6fa1b92f09017d4bca20f44 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Bj=C3=B6rn=20Jacke?= <bjacke@samba.org>
>Date: Thu, 19 Apr 2018 16:14:38 +0200
>Subject: [PATCH] printing: return the same error code as windows does on
> upload failures
>
>Some print drivers inf files are broken and cause driver installation to fail
>on Samba servers. Windows returns WERR_APP_INIT_FAILURE in that case, we should
>do the same. Windows machines are less unlucky with that.
>
>Signed-off-by: Bjoern Jacke <bjacke@samba.org>
>
>---
> source3/printing/nt_printing.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
>index 241af37743ef..54357b787f3e 100644
>--- a/source3/printing/nt_printing.c
>+++ b/source3/printing/nt_printing.c
>@@ -1217,7 +1217,7 @@ static WERROR move_driver_file_to_download_area(TALLOC_CTX *mem_ctx,
> 				 "to rename [%s] to [%s]: %s\n",
> 				 smb_fname_old->base_name, new_name,
> 				 nt_errstr(status)));
>-			ret = WERR_ACCESS_DENIED;
>+			ret = WERR_APP_INIT_FAILURE;
> 			goto out;
> 		}
> 	}
>-- 
>2.17.0
>

Flags:

bjacke: review+
asn: review+

Actions: View

Attachments on bug 13395: 14160