Attachment 14148 Details for Bug 13280 – Patch for v4-7-test

[patch] Patch for v4-7-test

tmp47.diff.txt (text/plain), 1.15 KB, created by Stefan Metzmacher on 2018-04-17 06:18:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2018-04-17 06:18:20 UTC

Size: 1.15 KB

patch

obsolete

>From 3279154d6736447dfe897bac5d618cb4f75d2fd9 Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Tue, 23 Jan 2018 23:52:59 +0100
>Subject: [PATCH] winbindd: initialize type = SID_NAME_UNKNOWN in
> wb_lookupsids_single_done()
>
>We check for !NT_STATUS_LOOKUP_ERR(), but wb_lookupsid_recv()
>only initializes the results together with NT_STATUS_OK.
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=13280
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Ralph Boehme <slow@samba.org>
>(cherry picked from commit b5ffa0e21f74fa0c452df38cf50e542eb278562d)
>---
> source3/winbindd/wb_lookupsids.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/winbindd/wb_lookupsids.c b/source3/winbindd/wb_lookupsids.c
>index 6a4ad68..bd90c43 100644
>--- a/source3/winbindd/wb_lookupsids.c
>+++ b/source3/winbindd/wb_lookupsids.c
>@@ -513,7 +513,7 @@ static void wb_lookupsids_single_done(struct tevent_req *subreq)
> 		req, struct wb_lookupsids_state);
> 	const char *domain_name = NULL;
> 	const char *name = NULL;
>-	enum lsa_SidType type;
>+	enum lsa_SidType type = SID_NAME_UNKNOWN;
> 	uint32_t res_sid_index;
> 	uint32_t src_rid;
> 
>-- 
>1.9.1
>

Flags:

slow: review+

Actions: View

Attachments on bug 13280: 13987 | 14148