Attachment 14116 Details for Bug 13375 – git-am fix for 4.7.next, 4.8.next.

[patch] git-am fix for 4.7.next, 4.8.next.

0001-s3-smbd-Unix-extensions-attempts-to-change-wrong-fie.patch (text/plain), 1.40 KB, created by Jeremy Allison on 2018-04-09 22:59:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2018-04-09 22:59:55 UTC

Size: 1.40 KB

patch

obsolete

>From 1f6d18abf9b3d16ab782839bb43492ed88d39d6e Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Mon, 9 Apr 2018 09:32:23 -0700
>Subject: [PATCH] s3: smbd: Unix extensions attempts to change wrong field in
> fchown call.
>
>Cut and paste error.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=13375
>
>Reported-by: Rungta, Vandana <vrungta@amazon.com>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>Reviewed-by: David Disseldorp <ddiss@samba.org>
>
>Autobuild-User(master): David Disseldorp <ddiss@samba.org>
>Autobuild-Date(master): Tue Apr 10 00:45:56 CEST 2018 on sn-devel-144
>
>(cherry picked from commit 3227b110d065500ed84fc70063da70ab35823a2e)
>---
> source3/smbd/trans2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
>index 512918efc89..0b62fd4f875 100644
>--- a/source3/smbd/trans2.c
>+++ b/source3/smbd/trans2.c
>@@ -7777,10 +7777,10 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn,
> 
> 		DEBUG(10,("smb_set_file_unix_basic: SMB_SET_FILE_UNIX_BASIC "
> 			  "changing group %u for file %s\n",
>-			  (unsigned int)set_owner,
>+			  (unsigned int)set_grp,
> 			  smb_fname_str_dbg(smb_fname)));
> 		if (fsp && fsp->fh->fd != -1) {
>-			ret = SMB_VFS_FCHOWN(fsp, set_owner, (gid_t)-1);
>+			ret = SMB_VFS_FCHOWN(fsp, (uid_t)-1, set_grp);
> 		} else {
> 			/*
> 			 * UNIX extensions calls must always operate
>-- 
>2.17.0.484.g0c8726318c-goog
>

Flags:

ddiss: review+

Actions: View

Attachments on bug 13375: 14116