The Samba-Bugzilla – Attachment 13961 Details for
Bug 13270
Leak of file descriptor in samba 4.5.11
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch.
0001-s3-smbd-Fix-possible-directory-fd-leak-if-the-underl.patch (text/plain), 1.22 KB, created by
Jeremy Allison
on 2018-02-14 21:25:47 UTC
(
hide
)
Description:
Proposed patch.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2018-02-14 21:25:47 UTC
Size:
1.22 KB
patch
obsolete
>From 1f09b75f6900a89b34da002a7aa6d3b2dae0308c Mon Sep 17 00:00:00 2001 >From: Jeremy Allison <jra@samba.org> >Date: Wed, 14 Feb 2018 13:23:12 -0800 >Subject: [PATCH] s3: smbd: Fix possible directory fd leak if the underlying OS > doesn't support FDOPENDIR() > >(HPUX I think has this problem). > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=13270 > >Signed-off-by: Jeremy Allison <jra@samba.org> >--- > source3/smbd/smb2_query_directory.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/source3/smbd/smb2_query_directory.c b/source3/smbd/smb2_query_directory.c >index 430fdca90de..888473853d4 100644 >--- a/source3/smbd/smb2_query_directory.c >+++ b/source3/smbd/smb2_query_directory.c >@@ -343,11 +343,14 @@ static struct tevent_req *smbd_smb2_query_directory_send(TALLOC_CTX *mem_ctx, > if (in_flags & SMB2_CONTINUE_FLAG_REOPEN) { > int flags; > >- dptr_CloseDir(fsp); >+ status = fd_close(fsp); >+ if (tevent_req_nterror(req, status)) { >+ return tevent_req_post(req, ev); >+ } > > /* >- * dptr_CloseDir() will close and invalidate the fsp's file >- * descriptor, we have to reopen it. >+ * fd_close() will close and invalidate the fsp's file >+ * descriptor. So we have to reopen it. > */ > > flags = O_RDONLY; >-- >2.14.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 13270
:
13961
|
13979