The Samba-Bugzilla – Attachment 13960 Details for
Bug 13269
RODC may skip objects during replication due to naming conflicts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch against returning LDB_SUCCESS upon failure
0001-repl_md-avoid-returning-LDB_SUCCESS-on-failure.patch (text/plain), 1.51 KB, created by
Douglas Bagnall
on 2018-02-14 04:20:13 UTC
(
hide
)
Description:
Patch against returning LDB_SUCCESS upon failure
Filename:
MIME Type:
Creator:
Douglas Bagnall
Created:
2018-02-14 04:20:13 UTC
Size:
1.51 KB
patch
obsolete
>From ad8c1db01355c766d4d29c6073a9895ceafd066e Mon Sep 17 00:00:00 2001 >From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> >Date: Wed, 14 Feb 2018 17:15:07 +1300 >Subject: [PATCH] repl_md: avoid returning LDB_SUCCESS on failure > >Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> >Signed-off-by: Garming Sam <garming@catalyst.net.nz> >--- > source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > >diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c >index 7646f942fca..1f5fe9a7090 100644 >--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c >+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c >@@ -5108,6 +5108,9 @@ failed: > * replication will stop with an error, but there is not much > * else we can do. > */ >+ if (ret == LDB_SUCCESS) { >+ ret = LDB_ERR_OPERATIONS_ERROR; >+ } > return ldb_module_done(ar->req, NULL, NULL, > ret); > } >@@ -5717,8 +5720,10 @@ static int replmd_replicated_handle_rename(struct replmd_replicated_request *ar, > ldb_errstring(ldb_module_get_ctx(ar->module)))); > goto failed; > } >-failed: > >+ talloc_free(tmp_ctx); >+ return ret; >+failed: > /* > * On failure make the caller get the error > * This means replication will stop with an error, >@@ -5726,6 +5731,9 @@ failed: > * LDB_ERR_ENTRY_ALREADY_EXISTS case this is exactly what is > * needed. > */ >+ if (ret == LDB_SUCCESS) { >+ ret = LDB_ERR_OPERATIONS_ERROR; >+ } > > talloc_free(tmp_ctx); > return ret; >-- >2.14.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 13269
: 13960 |
14005