From 413a4c7985c37f89fa8123c05135858cb3448462 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 25 Oct 2017 19:39:34 +0200 Subject: [PATCH] s3:vfs_glusterfs: Fix a double free in vfs_gluster_getwd() Found by cppcheck. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13100 Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison (cherry picked from commit 16389bed0773952ca563b7bf1fecc2a737587257) --- source3/modules/vfs_glusterfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c index 1c9be2d97f1..85d148335f0 100644 --- a/source3/modules/vfs_glusterfs.c +++ b/source3/modules/vfs_glusterfs.c @@ -1083,8 +1083,9 @@ static char *vfs_gluster_getwd(struct vfs_handle_struct *handle) } ret = glfs_getcwd(handle->data, cwd, PATH_MAX - 1); - if (ret == 0) { + if (ret == NULL) { free(cwd); + return NULL; } return ret; } -- 2.14.2