Attachment 13723 Details for Bug 13099 – patch for 4.7

[patch] patch for 4.7

ntstatus-v4-7.patch1.txt (text/plain), 1.52 KB, created by Andreas Schneider on 2017-10-26 05:57:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2017-10-26 05:57:19 UTC

Size: 1.52 KB

patch

obsolete

>From 6c211ab3aeb728fbbab98aff57db94f4711e7db2 Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Wed, 25 Oct 2017 17:37:24 +0200
>Subject: [PATCH] s4:scripting: Fix ntstatus_gen.h generation on 32bit
>
>The hex() function results in different output on 32bit systems. It adds
>a L for long for some numbers. Thus we have a different header file.
>
>This patch makes sure we have a consistent file generation on different
>paltforms.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=13099
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: David Disseldorp <ddiss@samba.org>
>
>Autobuild-User(master): David Disseldorp <ddiss@samba.org>
>Autobuild-Date(master): Wed Oct 25 22:28:39 CEST 2017 on sn-devel-144
>
>(cherry picked from commit 2d260b28f50ea6ee704d9fab2aaf26f760fa110f)
>---
> source4/scripting/bin/gen_ntstatus.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source4/scripting/bin/gen_ntstatus.py b/source4/scripting/bin/gen_ntstatus.py
>index 9592ab22bfd..9516c24fddc 100755
>--- a/source4/scripting/bin/gen_ntstatus.py
>+++ b/source4/scripting/bin/gen_ntstatus.py
>@@ -32,7 +32,7 @@ def generateHeaderFile(out_file, errors):
>     out_file.write("#ifndef _NTSTATUS_GEN_H\n")
>     out_file.write("#define _NTSTATUS_GEN_H\n")
>     for err in errors:
>-        line = "#define %s NT_STATUS(%s)\n" % (err.err_define, hex(err.err_code))
>+        line = "#define %s NT_STATUS(%#x)\n" % (err.err_define, err.err_code)
>         out_file.write(line)
>     out_file.write("\n#endif /* _NTSTATUS_GEN_H */\n")
> 
>-- 
>2.14.2
>

Flags:

ddiss: review+
ab: review+

Actions: View

Attachments on bug 13099: 13723