Attachment 13714 Details for Bug 13091 – patch for 4.6

[patch] patch for 4.6

0001-vfs_glusterfs-Fix-exporting-subdirs-with-shadow_copy.patch (text/plain), 1.90 KB, created by Anoop C S on 2017-10-23 06:30:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Anoop C S

Created: 2017-10-23 06:30:34 UTC

Size: 1.90 KB

patch

obsolete

>From 573462e4b72bb253f6a1e286e26401b6c2155b98 Mon Sep 17 00:00:00 2001
>From: Michael Adam <obnox@samba.org>
>Date: Fri, 20 Oct 2017 14:55:10 +0200
>Subject: [PATCH] vfs_glusterfs: Fix exporting subdirs with shadow_copy2
>
>Since the glusterfs vfs module does not operate on a
>locally mounted path, but on a "virtual" path starting
>at the volume root, some assumptions of the code about
>the vfs connect path fail. One example is the shadow_copy2
>module which tries to detect the mount point from the
>connectpath. In order to circumvent this problem, this
>patch forces the "shadow:mountpoint" option to "/", which
>skips the mount-point-detection code.
>
>This patch will only have an effect if both the glusterfs
>and the shadow_copy2 module are listed in vfs objects
>in the right order, i.e. first shadow_copy2, and then
>glusterfs.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=13091
>
>Pair-Programmed-With: Anoop C S <anoopcs@redhat.com>
>
>Signed-off-by: Michael Adam <obnox@samba.org>
>Signed-off-by: Anoop C S <anoopcs@redhat.com>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>(cherry picked from commit 1249801ec73c55449068dd72efde81ce6235ec8e)
>---
> source3/modules/vfs_glusterfs.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c
>index 1c9be2d97f1..2b6d827d21e 100644
>--- a/source3/modules/vfs_glusterfs.c
>+++ b/source3/modules/vfs_glusterfs.c
>@@ -352,6 +352,16 @@ static int vfs_gluster_connect(struct vfs_handle_struct *handle,
> 			  volume, strerror(errno)));
> 		goto done;
> 	}
>+
>+	/*
>+	 * The shadow_copy2 module will fail to export subdirectories
>+	 * of a gluster volume unless we specify the mount point,
>+	 * because the detection fails if the file system is not
>+	 * locally mounted:
>+	 * https://bugzilla.samba.org/show_bug.cgi?id=13091
>+	 */
>+	lp_do_parameter(SNUM(handle->conn), "shadow:mountpoint", "/");
>+
> done:
> 	if (ret < 0) {
> 		if (fs)
>-- 
>2.13.6
>

Flags:

jra: review+
gd: review+

Actions: View

Attachments on bug 13091: 13700 | 13713 | 13714