The Samba-Bugzilla – Attachment 13698 Details for
Bug 13086
Directory deletion from Mac terminal client resulted in smbd crash with vfs_fruit and vfs_glusterfs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch for 4.6
0001-vfs_fruit-Replace-closedir-by-SMB_VFS_CLOSEDIR.patch (text/plain), 1.56 KB, created by
Anoop C S
on 2017-10-17 05:43:56 UTC
(
hide
)
Description:
patch for 4.6
Filename:
MIME Type:
Creator:
Anoop C S
Created:
2017-10-17 05:43:56 UTC
Size:
1.56 KB
patch
obsolete
>From 749db9a4059a3150a97ca55766abed81786141f9 Mon Sep 17 00:00:00 2001 >From: Anoop C S <anoopcs@redhat.com> >Date: Fri, 13 Oct 2017 20:38:31 +0530 >Subject: [PATCH] vfs_fruit: Replace closedir() by SMB_VFS_CLOSEDIR >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Pointer to directory 'dh' inside fruit_rmdir() is obtained using >SMB_VFS_OPENDIR. But this handle is closed directly by invoking >closedir() rather than SMB_VFS_CLOSEDIR. This will result in a >smbd crash if this handle was not obtained from local file system. >Therefore use SMB_VFS_CLOSEDIR corresponding to SMB_VFS_OPENDIR >to correctly close the directory handle. > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=13086 > >Signed-off-by: Anoop C S <anoopcs@redhat.com> >Reviewed-by: Ralph Boehme <slow@samba.org> >Reviewed-by: Jeremy Allison <jra@samba.org> >Reviewed-by: Guenther Deschner <gd@samba.org> > >Autobuild-User(master): Günther Deschner <gd@samba.org> >Autobuild-Date(master): Mon Oct 16 19:56:55 CEST 2017 on sn-devel-144 > >(cherry picked from commit 7917f9721c9f8efdf9e7b7c50a9e5147250e36fe) >--- > source3/modules/vfs_fruit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c >index df0a7007636..a1b4783978c 100644 >--- a/source3/modules/vfs_fruit.c >+++ b/source3/modules/vfs_fruit.c >@@ -3561,7 +3561,7 @@ static int fruit_rmdir(struct vfs_handle_struct *handle, > > exit_rmdir: > if (dh) { >- closedir(dh); >+ SMB_VFS_CLOSEDIR(handle->conn, dh); > } > return SMB_VFS_NEXT_RMDIR(handle, smb_fname); > } >-- >2.13.6 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
slow
:
review+
gd
:
review+
Actions:
View
Attachments on
bug 13086
:
13684
|
13697
| 13698