Attachment 1369 Details for Bug 2984 – remove unused variables

[patch] remove unused variables

pdb.patch (text/plain), 1.79 KB, created by Jason Mader (mail bounces back) on 2005-08-12 08:05:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jason Mader (mail bounces back)

Created: 2005-08-12 08:05:20 UTC

Size: 1.79 KB

patch

obsolete

>Index: utils/pdbedit.c
>===================================================================
>--- utils/pdbedit.c	(revision 9260)
>+++ utils/pdbedit.c	(working copy)
>@@ -235,7 +235,7 @@
> static int print_users_list (struct pdb_context *in, BOOL verbosity, BOOL smbpwdstyle)
> {
> 	SAM_ACCOUNT *sam_pwent=NULL;
>-	BOOL check, ret;
>+	BOOL check;
> 	
> 	check = NT_STATUS_IS_OK(in->pdb_setsampwent(in, False, 0));
> 	if (!check) {
>@@ -245,7 +245,7 @@
> 	check = True;
> 	if (!(NT_STATUS_IS_OK(pdb_init_sam(&sam_pwent)))) return 1;
> 
>-	while (check && (ret = NT_STATUS_IS_OK(in->pdb_getsampwent (in, sam_pwent)))) {
>+	while (check && NT_STATUS_IS_OK(in->pdb_getsampwent (in, sam_pwent))) {
> 		if (verbosity)
> 			printf ("---------------\n");
> 		print_sam_info (sam_pwent, verbosity, smbpwdstyle);
>@@ -264,7 +264,7 @@
> static int fix_users_list (struct pdb_context *in)
> {
> 	SAM_ACCOUNT *sam_pwent=NULL;
>-	BOOL check, ret;
>+	BOOL check;
> 	
> 	check = NT_STATUS_IS_OK(in->pdb_setsampwent(in, False, 0));
> 	if (!check) {
>@@ -274,7 +274,7 @@
> 	check = True;
> 	if (!(NT_STATUS_IS_OK(pdb_init_sam(&sam_pwent)))) return 1;
> 
>-	while (check && (ret = NT_STATUS_IS_OK(in->pdb_getsampwent (in, sam_pwent)))) {
>+	while (check && NT_STATUS_IS_OK(in->pdb_getsampwent (in, sam_pwent))) {
> 		printf("Updating record for user %s\n", pdb_get_username(sam_pwent));
> 	
> 		if (!pdb_update_sam_account(sam_pwent)) {
>@@ -430,12 +430,12 @@
> 			const char *profile, char *user_sid, char *group_sid)
> {
> 	SAM_ACCOUNT *sam_pwent=NULL;
>-	NTSTATUS nt_status;
>+
> 	char *password1, *password2, *staticpass;
> 	
> 	get_global_sam_sid();
> 
>-	if (!NT_STATUS_IS_OK(nt_status = pdb_init_sam_new(&sam_pwent, username, 0))) {
>+	if (!NT_STATUS_IS_OK(pdb_init_sam_new(&sam_pwent, username, 0)) {
> 		DEBUG(0, ("could not create account to add new user %s\n", username));
> 		return -1;
> 	}

Actions: View

Attachments on bug 2984: 1369