Attachment 13634 Details for Bug 12991 – Patch for 4.6 and 4.7 cherry-picked from master

[patch] Patch for 4.6 and 4.7 cherry-picked from master

bug12991-v46,v47.patch (text/plain), 1.43 KB, created by Ralph Böhme on 2017-09-27 09:55:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralph Böhme

Created: 2017-09-27 09:55:00 UTC

Size: 1.43 KB

patch

obsolete

>From a3c23f59bf835c287c652b7e7346f47faddcbf3f Mon Sep 17 00:00:00 2001
>From: Ralph Boehme <slow@samba.org>
>Date: Sun, 27 Aug 2017 19:22:38 +0200
>Subject: [PATCH] s3/mdssvc: missing assignment in sl_pack_float
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Spotted by -Werror=maybe-uninitialized:
>
>../source3/rpc_server/mdssvc/marshalling.c: In function âsl_pack_floatâ:
>../source3/rpc_server/mdssvc/marshalling.c:171:11: error:
>âieee_fp_union.wâ may be used uninitialized in this function
>[-Werror=maybe-uninitialized]
>  offset = sl_push_uint64_val(buf, offset, bufsize, ieee_fp_union.w);
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=12991
>
>Signed-off-by: Ralph Boehme <slow@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>(cherry picked from commit 7b58c8f54499f01778bcbfc2ad21521ceed2dd57)
>---
> source3/rpc_server/mdssvc/marshalling.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/source3/rpc_server/mdssvc/marshalling.c b/source3/rpc_server/mdssvc/marshalling.c
>index 0a02f418722..976702c49d4 100644
>--- a/source3/rpc_server/mdssvc/marshalling.c
>+++ b/source3/rpc_server/mdssvc/marshalling.c
>@@ -164,6 +164,8 @@ static ssize_t sl_pack_float(double d, char *buf, ssize_t offset, size_t bufsize
> 		uint64_t w;
> 	} ieee_fp_union;
> 
>+	ieee_fp_union.d = d;
>+
> 	offset = sl_push_uint64_val(buf, offset, bufsize, sl_pack_tag(SQ_TYPE_FLOAT, 2, 1));
> 	if (offset == -1) {
> 		return -1;
>-- 
>2.13.5
>

Flags:

jra: review+
slow: review? (metze)

Actions: View

Attachments on bug 12991: 13634