Attachment 13615 Details for Bug 12144 – cherry-picked test for 4.6.next

[patch] cherry-picked test for 4.6.next

torture-ioctl-test-set_compression-format_none.patch (text/plain), 1.70 KB, created by David Disseldorp on 2017-09-20 17:26:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Disseldorp

Created: 2017-09-20 17:26:47 UTC

Size: 1.70 KB

patch

obsolete

>From 0649f24889f7bdb3dd14dbbfd030207c7b1decd7 Mon Sep 17 00:00:00 2001
>From: David Disseldorp <ddiss@samba.org>
>Date: Thu, 5 Jan 2017 17:10:42 +0100
>Subject: [PATCH] torture/ioctl: test set_compression(format_none)
>
>This test case was overlooked in the previous bso#12144 update -
>set compression requests with format=COMPRESSION_FORMAT_NONE should
>succeed if the server / backing storage doesn't offer compression
>support.
>Confirm that Samba matches Windows Server 2016 ReFS behaviour here.
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=12144
>
>Reported-by: Nick Barrett <nick@barrett.org.nz>
>Signed-off-by: David Disseldorp <ddiss@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>(cherry picked from commit 6fde123176409e261d955e24b3d28e5124f33bed)
>---
> source4/torture/smb2/ioctl.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/source4/torture/smb2/ioctl.c b/source4/torture/smb2/ioctl.c
>index 01cc1500aab..54a36a86036 100644
>--- a/source4/torture/smb2/ioctl.c
>+++ b/source4/torture/smb2/ioctl.c
>@@ -2608,7 +2608,16 @@ static bool test_ioctl_compress_notsup_set(struct torture_context *torture,
> 					 COMPRESSION_FORMAT_DEFAULT);
> 	torture_assert_ntstatus_equal(torture, status,
> 				      NT_STATUS_NOT_SUPPORTED,
>-				      "FSCTL_GET_COMPRESSION");
>+				      "FSCTL_SET_COMPRESSION default");
>+
>+	/*
>+	 * Despite not supporting compression, we should get a successful
>+	 * response for set(COMPRESSION_FORMAT_NONE) - like WS2016 ReFS.
>+	 */
>+	status = test_ioctl_compress_set(torture, tmp_ctx, tree, fh,
>+					 COMPRESSION_FORMAT_NONE);
>+	torture_assert_ntstatus_ok(torture, status,
>+				   "FSCTL_SET_COMPRESSION none");
> 
> 	smb2_util_close(tree, fh);
> 	talloc_free(tmp_ctx);
>-- 
>2.13.5
>

Flags:

jra: review+

Actions: View

Attachments on bug 12144: 12539 | 12548 | 12549 | 12805 | 12806 | 13583 | 13615