Attachment 13551 Details for Bug 13006 – Patch

[patch] Patch

4-7.patch (text/plain), 1.20 KB, created by Volker Lendecke on 2017-09-06 15:09:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2017-09-06 15:09:51 UTC

Size: 1.20 KB

patch

obsolete

>From f288e5a48e64887c0141adfa291df2b5a47fe7ef Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Wed, 30 Aug 2017 17:49:54 +0200
>Subject: [PATCH] messaging: Avoid a socket leak after fork
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=13006
>
>Signed-off-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Stefan Metzmacher <metze@samba.org>
>
>Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
>Autobuild-Date(master): Tue Sep  5 19:12:34 CEST 2017 on sn-devel-144
>
>(cherry picked from commit d1c96dc0ac95322ce46703a11002873faf55a26c)
>---
> source3/lib/messages_dgm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/source3/lib/messages_dgm.c b/source3/lib/messages_dgm.c
>index f29180d7ec2..9d87746fa2c 100644
>--- a/source3/lib/messages_dgm.c
>+++ b/source3/lib/messages_dgm.c
>@@ -280,7 +280,8 @@ static int messaging_dgm_out_destructor(struct messaging_dgm_out *out)
> {
> 	DLIST_REMOVE(out->ctx->outsocks, out);
> 
>-	if (tevent_queue_length(out->queue) != 0) {
>+	if ((tevent_queue_length(out->queue) != 0) &&
>+	    (getpid() == out->ctx->pid)) {
> 		/*
> 		 * We have pending jobs. We can't close the socket,
> 		 * this has been handed over to messaging_dgm_out_queue_state.
>-- 
>2.11.0
>

Flags:

jra: review+

Actions: View

Attachments on bug 13006: 13530 | 13531 | 13532 | 13533 | 13551