The Samba-Bugzilla – Attachment 13509 Details for
Bug 12993
AD published printers are pruned from directory
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
For v4-4-test
0001-s3-spoolss-Fix-GUID-string-format-on-GetPrinter-info.patch (text/plain), 1.59 KB, created by
Samuel Cabrero
on 2017-08-28 11:15:36 UTC
(
hide
)
Description:
For v4-4-test
Filename:
MIME Type:
Creator:
Samuel Cabrero
Created:
2017-08-28 11:15:36 UTC
Size:
1.59 KB
patch
obsolete
>From 2caaf29734dc0853e277d2629e4afc94a8186a91 Mon Sep 17 00:00:00 2001 >From: Samuel Cabrero <scabrero@suse.de> >Date: Mon, 28 Aug 2017 12:46:27 +0200 >Subject: [PATCH] s3:spoolss: Fix GUID string format on GetPrinter info level 7 > >Fix regression introduced by commit a4157e7c5d75 which removed the braces >around the printer GUID in the printer info level 7 structure. >MS-RPRN section 2.2 says this protocol uses curly-braced GUIDs so printers >are deleted from the directory by the domain controller's pruning service. > >Signed-off-by: Samuel Cabrero <scabrero@suse.de> >--- > source3/rpc_server/spoolss/srv_spoolss_nt.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c >index a15547115b4..588960564fb 100644 >--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c >+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c >@@ -4230,7 +4230,6 @@ static WERROR construct_printer_info7(TALLOC_CTX *mem_ctx, > if (is_printer_published(tmp_ctx, session_info, msg_ctx, > servername, printer, NULL)) { > struct GUID guid; >- struct GUID_txt_buf guid_txt; > werr = nt_printer_guid_get(tmp_ctx, session_info, msg_ctx, > printer, &guid); > if (!W_ERROR_IS_OK(werr)) { >@@ -4254,8 +4253,7 @@ static WERROR construct_printer_info7(TALLOC_CTX *mem_ctx, > printer)); > } > } >- r->guid = talloc_strdup_upper(mem_ctx, >- GUID_buf_string(&guid, &guid_txt)); >+ r->guid = talloc_strdup_upper(mem_ctx, GUID_string2(mem_ctx, &guid)); > r->action = DSPRINT_PUBLISH; > } else { > r->guid = talloc_strdup(mem_ctx, ""); >-- >2.14.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
ddiss
:
review+
Actions:
View
Attachments on
bug 12993
:
13509
|
13620
|
13661
|
13662
|
13663
|
13664