From 2caaf29734dc0853e277d2629e4afc94a8186a91 Mon Sep 17 00:00:00 2001 From: Samuel Cabrero Date: Mon, 28 Aug 2017 12:46:27 +0200 Subject: [PATCH] s3:spoolss: Fix GUID string format on GetPrinter info level 7 Fix regression introduced by commit a4157e7c5d75 which removed the braces around the printer GUID in the printer info level 7 structure. MS-RPRN section 2.2 says this protocol uses curly-braced GUIDs so printers are deleted from the directory by the domain controller's pruning service. Signed-off-by: Samuel Cabrero --- source3/rpc_server/spoolss/srv_spoolss_nt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index a15547115b4..588960564fb 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -4230,7 +4230,6 @@ static WERROR construct_printer_info7(TALLOC_CTX *mem_ctx, if (is_printer_published(tmp_ctx, session_info, msg_ctx, servername, printer, NULL)) { struct GUID guid; - struct GUID_txt_buf guid_txt; werr = nt_printer_guid_get(tmp_ctx, session_info, msg_ctx, printer, &guid); if (!W_ERROR_IS_OK(werr)) { @@ -4254,8 +4253,7 @@ static WERROR construct_printer_info7(TALLOC_CTX *mem_ctx, printer)); } } - r->guid = talloc_strdup_upper(mem_ctx, - GUID_buf_string(&guid, &guid_txt)); + r->guid = talloc_strdup_upper(mem_ctx, GUID_string2(mem_ctx, &guid)); r->action = DSPRINT_PUBLISH; } else { r->guid = talloc_strdup(mem_ctx, ""); -- 2.14.1