From b93927cf689ca3c7ab29af36243927c3cba5b73c Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Thu, 20 Jul 2017 11:56:21 +0200 Subject: [PATCH] s4:http/gensec: add missing tevent_req_done() to gensec_http_ntlm_update_done() This was missing in commit d718e92d5e145dccd492c46febc249e462ce50c6. Sadly we can't have automated tests for this as we only implement the client side for this protocol. I've tested with using: bin/smbtorture \ -W BLA --realm=BLA.BASE \ -s /dev/null -Uadministrator%A1b2C3d4 \ ncacn_http:w2k8r2-219[593,RpcProxy=w2k8r2-219.bla.base,HttpUseTls=false,HttpAuthOption=basic] \ rpc.epmapper.epmapper.Lookup_simple \ and: bin/smbtorture \ -W BLA --realm=BLA.BASE \ -s /dev/null -Uadministrator%A1b2C3d4 \ ncacn_http:w2k8r2-219[593,RpcProxy=w2k8r2-219.bla.base,HttpUseTls=false,HttpAuthOption=ntlm] \ rpc.epmapper.epmapper.Lookup_simple \ BUG: https://bugzilla.samba.org/show_bug.cgi?id=12919 Signed-off-by: Stefan Metzmacher Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Fri Jul 21 23:29:39 CEST 2017 on sn-devel-144 (cherry picked from commit 13f91927e0f642e58c70d7b0b2f68df861ac661c) --- source4/lib/http/gensec/ntlm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/lib/http/gensec/ntlm.c b/source4/lib/http/gensec/ntlm.c index 7d692ed9b7d..788fb7d3636 100644 --- a/source4/lib/http/gensec/ntlm.c +++ b/source4/lib/http/gensec/ntlm.c @@ -134,7 +134,7 @@ static void gensec_http_ntlm_update_done(struct tevent_req *subreq) } state->out = data_blob_string_const(str); - return; + tevent_req_done(req); } static NTSTATUS gensec_http_ntlm_update_recv(struct tevent_req *req, -- 2.14.1.480.gb18f417b89-goog