The Samba-Bugzilla – Attachment 13468 Details for
Bug 12959
backupkey uses variables with wrong scope
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch for 4.7
backupkey.patch (text/plain), 1.90 KB, created by
Andreas Schneider
on 2017-08-14 06:59:12 UTC
(
hide
)
Description:
patch for 4.7
Filename:
MIME Type:
Creator:
Andreas Schneider
Created:
2017-08-14 06:59:12 UTC
Size:
1.90 KB
patch
obsolete
>From 856256b1cce319126a061a80a0f294db35d6d6dc Mon Sep 17 00:00:00 2001 >From: Andreas Schneider <asn@samba.org> >Date: Tue, 18 Jul 2017 12:49:05 +0200 >Subject: [PATCH] s4:rpc_server:backupkey: Move variable into scope > >CID: #1415510 > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=12959 > >Signed-off-by: Andreas Schneider <asn@samba.org> >Reviewed-by: Stefan Metzmacher <metze@samba.org> >(cherry picked from commit 4791c152b02a47a59fe33870741b2f4c80351e55) >--- > source4/rpc_server/backupkey/dcesrv_backupkey.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/source4/rpc_server/backupkey/dcesrv_backupkey.c b/source4/rpc_server/backupkey/dcesrv_backupkey.c >index 444910bf409..cf9af1fbc31 100644 >--- a/source4/rpc_server/backupkey/dcesrv_backupkey.c >+++ b/source4/rpc_server/backupkey/dcesrv_backupkey.c >@@ -360,6 +360,8 @@ static WERROR get_and_verify_access_check(TALLOC_CTX *sub_ctx, > uint32_t access_check_len, > struct auth_session_info *session_info) > { >+ struct bkrp_access_check_v2 uncrypted_accesscheckv2; >+ struct bkrp_access_check_v3 uncrypted_accesscheckv3; > gnutls_cipher_hd_t cipher_handle = { 0 }; > gnutls_cipher_algorithm_t cipher_algo; > DATA_BLOB blob_us; >@@ -422,7 +424,6 @@ static WERROR get_and_verify_access_check(TALLOC_CTX *sub_ctx, > uint32_t hash_size = 20; > uint8_t hash[hash_size]; > gnutls_hash_hd_t dig_ctx; >- struct bkrp_access_check_v2 uncrypted_accesscheckv2; > > ndr_err = ndr_pull_struct_blob(&blob_us, sub_ctx, &uncrypted_accesscheckv2, > (ndr_pull_flags_fn_t)ndr_pull_bkrp_access_check_v2); >@@ -457,7 +458,6 @@ static WERROR get_and_verify_access_check(TALLOC_CTX *sub_ctx, > uint32_t hash_size = 64; > uint8_t hash[hash_size]; > gnutls_hash_hd_t dig_ctx; >- struct bkrp_access_check_v3 uncrypted_accesscheckv3; > > ndr_err = ndr_pull_struct_blob(&blob_us, sub_ctx, &uncrypted_accesscheckv3, > (ndr_pull_flags_fn_t)ndr_pull_bkrp_access_check_v3); >-- >2.14.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
slow
:
review+
Actions:
View
Attachments on
bug 12959
: 13468