Attachment 13422 Details for Bug 12911 – fix for 4.5.next

[patch] fix for 4.5.next

0001-vfs_ceph-fix-cephwrap_chdir_4-5-test.patch (text/plain), 1.41 KB, created by David Disseldorp on 2017-07-24 09:47:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Disseldorp

Created: 2017-07-24 09:47:52 UTC

Size: 1.41 KB

patch

obsolete

>From 2b58957bae602025e5beaa0a20e739a0160fa185 Mon Sep 17 00:00:00 2001
>From: David Disseldorp <ddiss@samba.org>
>Date: Fri, 14 Jul 2017 23:55:29 +0200
>Subject: [PATCH] vfs_ceph: fix cephwrap_chdir()
>
>When provided a '/' path (i.e. CephFS root), vfs_ceph does a *local*
>chdir() to the share path. This breaks smb client directory listings.
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=12911
>
>Signed-off-by: David Disseldorp <ddiss@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>
>Autobuild-User(master): David Disseldorp <ddiss@samba.org>
>Autobuild-Date(master): Fri Jul 21 19:10:46 CEST 2017 on sn-devel-144
>
>(cherry picked from commit 1dcacff083019810e207a3d123a81fe32d9dde1a)
>---
> source3/modules/vfs_ceph.c | 7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/source3/modules/vfs_ceph.c b/source3/modules/vfs_ceph.c
>index 59e9b9cf9b3..9c7a2fb5f35 100644
>--- a/source3/modules/vfs_ceph.c
>+++ b/source3/modules/vfs_ceph.c
>@@ -750,13 +750,6 @@ static int cephwrap_chdir(struct vfs_handle_struct *handle,  const char *path)
> {
> 	int result = -1;
> 	DEBUG(10, ("[CEPH] chdir(%p, %s)\n", handle, path));
>-	/*
>-	 * If the path is just / use chdir because Ceph is below / and
>-	 * cannot deal with changing directory above its mount point
>-	 */
>-	if (path && !strcmp(path, "/"))
>-		return chdir(path);
>-
> 	result = ceph_chdir(handle->data, path);
> 	DEBUG(10, ("[CEPH] chdir(...) = %d\n", result));
> 	WRAP_RETURN(result);
>-- 
>2.12.3
>

Flags:

jra: review+

Actions: View

Attachments on bug 12911: 13390 | 13409 | 13422 | 13423