Attachment 13411 Details for Bug 12926 – patch for master

[patch] patch for master

0001-s4-drepl-Block-GetNCChanges-during-a-DsReplicaSync.patch (text/plain), 1.16 KB, created by Andrew Bartlett on 2017-07-22 10:16:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Bartlett

Created: 2017-07-22 10:16:50 UTC

Size: 1.16 KB

patch

obsolete

>From f816af781a2f109ab7a7e9ea5de4115059649821 Mon Sep 17 00:00:00 2001
>From: Andrew Bartlett <abartlet@samba.org>
>Date: Sat, 22 Jul 2017 22:00:59 +1200
>Subject: [PATCH] s4-drepl: Block GetNCChanges during a DsReplicaSync
>
>If we do not block these, we can get RPC faults
>(DCERPC_NCA_S_PROTO_ERROR) which gives WERR_WRITE_FAULT back to the
>DsReplicaSync call as there are two outstanding requests on the wire
>at the one time.
>
>We will get to the next operation as soon as this is finished
>when we call run_pending_ops().
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=12926
>
>Signed-off-by: Andrew Bartlett <abartlet@samba.org>
>---
> source4/dsdb/repl/drepl_out_pull.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source4/dsdb/repl/drepl_out_pull.c b/source4/dsdb/repl/drepl_out_pull.c
>index 8af6412..8b8ecd9 100644
>--- a/source4/dsdb/repl/drepl_out_pull.c
>+++ b/source4/dsdb/repl/drepl_out_pull.c
>@@ -198,7 +198,7 @@ void dreplsrv_run_pull_ops(struct dreplsrv_service *s)
> 	struct tevent_req *subreq;
> 	WERROR werr;
> 
>-	if (s->ops.current) {
>+	if (s->ops.n_current || s->ops.current) {
> 		/* if there's still one running, we're done */
> 		return;
> 	}
>-- 
>2.9.4
>

Actions: View

Attachments on bug 12926: 13411 | 13415 | 13416 | 13421