From 2a286daed9b1ab8c6bf58b171d9343158bd64233 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Fri, 12 May 2017 09:10:19 +0200 Subject: [PATCH] auth/spnego: fix gensec_update_ev() argument order for the SPNEGO_FALLBACK case This went unnoticed so long as we don't use -Wc++-compat and gensec_update_ev() used the sync update() hook for all NTLMSSP and Kerberos. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12788 Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett (cherry picked from commit 31691963b3d9ac460df0c56d36f81ec815db0225) --- auth/gensec/spnego.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/auth/gensec/spnego.c b/auth/gensec/spnego.c index 064ded8..8dddb13 100644 --- a/auth/gensec/spnego.c +++ b/auth/gensec/spnego.c @@ -366,7 +366,7 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec return nt_status; } nt_status = gensec_update_ev(spnego_state->sub_sec_security, - ev, out_mem_ctx, in, out); + out_mem_ctx, ev, in, out); return nt_status; } DEBUG(1, ("Failed to parse SPNEGO request\n")); @@ -804,8 +804,8 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA switch (spnego_state->state_position) { case SPNEGO_FALLBACK: - return gensec_update_ev(spnego_state->sub_sec_security, ev, - out_mem_ctx, in, out); + return gensec_update_ev(spnego_state->sub_sec_security, + out_mem_ctx, ev, in, out); case SPNEGO_SERVER_START: { NTSTATUS nt_status; -- 1.9.1