Attachment 13196 Details for Bug 12767 – Patch for v4-6-test

[patch] Patch for v4-6-test

tmp46.diff.txt (text/plain), 1.56 KB, created by Stefan Metzmacher on 2017-05-08 09:02:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2017-05-08 09:02:28 UTC

Size: 1.56 KB

patch

obsolete

>From 5a49d78619a4c153e05e23a87e6cfeeb8661f33f Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Tue, 25 Apr 2017 13:25:57 +0200
>Subject: [PATCH] samba-tool: let 'samba-tool user syncpasswords' report
> deletions immediately
>
>We need to use the show-recycled control in addition to the
>notification control in order to get notifications about deletions.
>
>There's no real problem as the next modification will report the deletion.
>But it might be delayed a few minutes.
>
>Note that show-recycled is a superset of show-deleted, so we only need one.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=12767
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Andreas Schneider <asn@samba.org>
>(cherry picked from commit afa15e6128473d3e4006f7cdc3762ab4c1cba05a)
>---
> python/samba/netcmd/user.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/python/samba/netcmd/user.py b/python/samba/netcmd/user.py
>index f007ee5..858ade4 100644
>--- a/python/samba/netcmd/user.py
>+++ b/python/samba/netcmd/user.py
>@@ -1861,7 +1861,7 @@ samba-tool user syncpasswords --terminate \\
> 
>         def sync_loop(wait):
>             notify_attrs = ["name", "uSNCreated", "uSNChanged", "objectClass"]
>-            notify_controls = ["notification:1"]
>+            notify_controls = ["notification:1", "show_recycled:1"]
>             notify_handle = self.samdb.search_iterator(expression="objectClass=*",
>                                                        scope=ldb.SCOPE_SUBTREE,
>                                                        attrs=notify_attrs,
>-- 
>1.9.1
>

Flags:

asn: review+

Actions: View

Attachments on bug 12767: 13196 | 13197