The Samba-Bugzilla – Attachment 13155 Details for
Bug 12747
wrong use of getgroups causes buffer overflow
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
fix use of getgroups
samba-fix-overflow-get_current_groups.diff (text/plain), 608 bytes, created by
Hanno Böck
on 2017-04-15 21:35:53 UTC
(
hide
)
Description:
fix use of getgroups
Filename:
MIME Type:
Creator:
Hanno Böck
Created:
2017-04-15 21:35:53 UTC
Size:
608 bytes
patch
obsolete
>diff -Naurp a/source3/smbd/sec_ctx.c b/source3/smbd/sec_ctx.c >--- a/source3/smbd/sec_ctx.c 2017-01-11 08:55:15.000000000 +0100 >+++ b/source3/smbd/sec_ctx.c 2017-04-15 19:18:01.613270638 +0200 >@@ -139,7 +139,6 @@ static void gain_root(void) > static int get_current_groups(gid_t gid, uint32_t *p_ngroups, gid_t **p_groups) > { > int i; >- gid_t grp; > int ngroups; > gid_t *groups = NULL; > >@@ -153,7 +152,7 @@ static int get_current_groups(gid_t gid, > set_effective_gid(gid); > samba_setgid(gid); > >- ngroups = sys_getgroups(0,&grp); >+ ngroups = sys_getgroups(0, NULL); > if (ngroups <= 0) { > goto fail; > }
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=13155">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 12747
:
13155
|
13156
|
13160