Attachment 13027 Details for Bug 12613 – Patch for v4-6-test

[patch] Patch for v4-6-test

tmp46.diff.txt (text/plain), 1.55 KB, created by Stefan Metzmacher on 2017-03-08 09:36:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2017-03-08 09:36:48 UTC

Size: 1.55 KB

patch

obsolete

>From 8ae1c0f3029fb7cd6504c47d87031301ef8ca6ba Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Mon, 6 Mar 2017 11:53:09 +0000
>Subject: [PATCH] idmap_autorid: allocate new domain range if the callers knows
> the sid is valid
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=12613
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>
>Autobuild-User(master): Jeremy Allison <jra@samba.org>
>Autobuild-Date(master): Wed Mar  8 04:06:59 CET 2017 on sn-devel-144
>
>(cherry picked from commit e015748657e9ee755b04f55f088c78bd025378cc)
>---
> source3/winbindd/idmap_autorid.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/source3/winbindd/idmap_autorid.c b/source3/winbindd/idmap_autorid.c
>index 786f839..ab89d35 100644
>--- a/source3/winbindd/idmap_autorid.c
>+++ b/source3/winbindd/idmap_autorid.c
>@@ -636,6 +636,19 @@ static NTSTATUS idmap_autorid_sid_to_id(struct idmap_tdb_common_context *common,
> 	}
> 
> 	/*
>+	 * If the caller already did a lookup sid and made sure the
>+	 * domain sid is valid, we can allocate a new range.
>+	 *
>+	 * Currently the winbindd parent already does a lookup sids
>+	 * first, but hopefully changes in future. If the
>+	 * caller knows the domain sid, ID_TYPE_BOTH should be
>+	 * passed instead of ID_TYPE_NOT_SPECIFIED.
>+	 */
>+	if (map->xid.type != ID_TYPE_NOT_SPECIFIED) {
>+		goto allocate;
>+	}
>+
>+	/*
> 	 * Check of last resort: A domain is valid if a user from that
> 	 * domain has recently logged in. The samlogon_cache these
> 	 * days also stores the domain sid.
>-- 
>1.9.1
>

Flags:

jra: review+

Actions: View

Attachments on bug 12613: 13023 | 13027