Attachment 12962 Details for Bug 12585 – Patch for v4-4-test

[patch] Patch for v4-4-test

tmp44.diff.txt (text/plain), 1.80 KB, created by Stefan Metzmacher on 2017-02-22 17:46:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2017-02-22 17:46:12 UTC

Size: 1.80 KB

patch

obsolete

>From d133eac14f95929c4683bff6fe9c5aeebb3626ca Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Wed, 15 Feb 2017 08:07:06 +0100
>Subject: [PATCH] librpc/rpc: fix regression in
> NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE error mapping
>
>Commit 1eef70872930fa4f9d3dedd23476b34cae638428 changed the mapping for
>DCERPC_NCA_S_FAULT_INVALID_TAG from NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE
>to NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=12585
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Ralph Boehme <slow@samba.org>
>(cherry picked from commit c97e39b34fcf260ded42ef1a9efe7ed55e65a1cf)
>---
> librpc/rpc/dcerpc_error.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/librpc/rpc/dcerpc_error.c b/librpc/rpc/dcerpc_error.c
>index f386025..8af0e71 100644
>--- a/librpc/rpc/dcerpc_error.c
>+++ b/librpc/rpc/dcerpc_error.c
>@@ -50,12 +50,10 @@ static const struct dcerpc_fault_table dcerpc_faults[] =
> 	_FAULT_STR(DCERPC_NCA_S_FAULT_INT_DIV_BY_ZERO, NT_STATUS_RPC_FP_DIV_ZERO),
> 	_FAULT_STR(DCERPC_NCA_S_FAULT_INT_OVERFLOW, NT_STATUS_RPC_FP_OVERFLOW),
> 	/*
>-	 * What's the difference between NT_STATUS_RPC_INVALID_TAG
>-	 * and NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE ???
>-	 *
>-	 * Our callers expect NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE.
>+	 * Our callers expect NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE
>+	 * instead of NT_STATUS_RPC_INVALID_TAG.
> 	 */
>-	_FAULT_STR(DCERPC_NCA_S_FAULT_INVALID_TAG, NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE),
>+	_FAULT_STR(DCERPC_NCA_S_FAULT_INVALID_TAG, NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE),
> 	_FAULT_STR(DCERPC_NCA_S_FAULT_INVALID_TAG, NT_STATUS_RPC_INVALID_TAG),
> 	_FAULT_STR(DCERPC_NCA_S_FAULT_INVALID_BOUND, NT_STATUS_RPC_INVALID_BOUND),
> 	_FAULT_STR(DCERPC_NCA_S_FAULT_RPC_VERSION_MISMATCH, NT_STATUS_RPC_PROTOCOL_ERROR),
>-- 
>1.9.1
>

Flags:

slow: review+

Actions: View

Attachments on bug 12585: 12960 | 12961 | 12962