Attachment 12899 Details for Bug 12551 – Patch for 4.6, 4.5 and 4.4 with cherry-pick info

[patch] Patch for 4.6, 4.5 and 4.4 with cherry-pick info

12551.patch (text/plain), 1.28 KB, created by Volker Lendecke on 2017-02-02 11:17:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2017-02-02 11:17:33 UTC

Size: 1.28 KB

patch

obsolete

>From 46d3b00fc1ea9d1bca328b8d833e3e2cc216ac95 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Wed, 1 Feb 2017 14:41:43 +0000
>Subject: [PATCH] smbd: Fix "map acl inherit" = yes
>
>Brown-Paper-Bag bug in f85c2a6852a. The assignment contains a self-reference
>in get_pai_flags which I missed.
>
>Fix an uninitialized read.
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=12551
>Signed-off-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Stefan Metzmacher <metze@samba.org>
>
>Autobuild-User(master): Volker Lendecke <vl@samba.org>
>Autobuild-Date(master): Wed Feb  1 22:06:50 CET 2017 on sn-devel-144
>
>(cherry picked from commit 129bc58eee4b1868b1aaec6194808752520517b4)
>---
> source3/smbd/posix_acls.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c
>index d87253d..e2a10cf 100644
>--- a/source3/smbd/posix_acls.c
>+++ b/source3/smbd/posix_acls.c
>@@ -2700,9 +2700,9 @@ static canon_ace *canonicalise_acl(struct connection_struct *conn,
> 			.attr = ALLOW_ACE,
> 			.trustee = sid,
> 			.unix_ug = unix_ug,
>-			.owner_type = owner_type,
>-			.ace_flags = get_pai_flags(pal, ace, is_default_acl)
>+			.owner_type = owner_type
> 		};
>+		ace->ace_flags = get_pai_flags(pal, ace, is_default_acl);
> 
> 		DLIST_ADD(l_head, ace);
> 	}
>-- 
>2.1.4
>

Actions: View

Attachments on bug 12551: 12896 | 12899