The Samba-Bugzilla – Attachment 12898 Details for
Bug 12546
vfs_streams_xattr doesn't cope with server changing directories
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
git-am fix for 4.6.next, 4.5.next, 4.4.next.
0001-s3-VFS-vfs_streams_xattr.c-Make-streams_xattr_open-s.patch (text/plain), 1.84 KB, created by
Jeremy Allison
on 2017-02-02 01:06:49 UTC
(
hide
)
Description:
git-am fix for 4.6.next, 4.5.next, 4.4.next.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2017-02-02 01:06:49 UTC
Size:
1.84 KB
patch
obsolete
>From 3d0d95c032e746b3676987356e311e61c4d88004 Mon Sep 17 00:00:00 2001 >From: Jeremy Allison <jra@samba.org> >Date: Wed, 1 Feb 2017 11:36:25 -0800 >Subject: [PATCH] s3: VFS: vfs_streams_xattr.c: Make streams_xattr_open() store > the same path as streams_xattr_recheck(). >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >If the open is changing directories, fsp->fsp_name->base_name >will be the full path from the share root, whilst >smb_fname will be relative to the $cwd. > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=12546 > >Signed-off-by: Jeremy Allison <jra@samba.org> >Reviewed-by: Ralph Böhme <slow@samba.org> > >Autobuild-User(master): Jeremy Allison <jra@samba.org> >Autobuild-Date(master): Thu Feb 2 01:55:42 CET 2017 on sn-devel-144 > >(cherry picked from commit a24ba3e4083200ec9885363efc5769f43183fb6b) >--- > source3/modules/vfs_streams_xattr.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/source3/modules/vfs_streams_xattr.c b/source3/modules/vfs_streams_xattr.c >index d9eb2e10852..d3c988c9c5e 100644 >--- a/source3/modules/vfs_streams_xattr.c >+++ b/source3/modules/vfs_streams_xattr.c >@@ -527,8 +527,15 @@ static int streams_xattr_open(vfs_handle_struct *handle, > > sio->xattr_name = talloc_strdup(VFS_MEMCTX_FSP_EXTENSION(handle, fsp), > xattr_name); >+ /* >+ * so->base needs to be a copy of fsp->fsp_name->base_name, >+ * making it identical to streams_xattr_recheck(). If the >+ * open is changing directories, fsp->fsp_name->base_name >+ * will be the full path from the share root, whilst >+ * smb_fname will be relative to the $cwd. >+ */ > sio->base = talloc_strdup(VFS_MEMCTX_FSP_EXTENSION(handle, fsp), >- smb_fname->base_name); >+ fsp->fsp_name->base_name); > sio->fsp_name_ptr = fsp->fsp_name; > sio->handle = handle; > sio->fsp = fsp; >-- >2.11.0.483.g087da7b7c-goog >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
slow
:
review+
Actions:
View
Attachments on
bug 12546
:
12897
| 12898