Attachment 12681 Details for Bug 12434 – Patches for v4-5

[patch] Patches for v4-5

BZ12434-v4-5.patch (text/plain), 1.09 KB, created by Amitay Isaacs on 2016-11-22 00:08:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Amitay Isaacs

Created: 2016-11-22 00:08:44 UTC

Size: 1.09 KB

patch

obsolete

>From fe62a0c39e7279cb9430e0c35ee78e5473ace8c9 Mon Sep 17 00:00:00 2001
>From: Amitay Isaacs <amitay@gmail.com>
>Date: Fri, 18 Nov 2016 11:47:56 +1100
>Subject: [PATCH] ctdb-recovery: Avoid NULL dereference in failure case
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=12434
>
>Signed-off-by: Amitay Isaacs <amitay@gmail.com>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>
>Autobuild-User(master): Volker Lendecke <vl@samba.org>
>Autobuild-Date(master): Mon Nov 21 12:26:04 CET 2016 on sn-devel-144
>
>(cherry picked from commit 54e392b385728bba047404465207340a2e354ec6)
>---
> ctdb/server/ctdb_recovery_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/ctdb/server/ctdb_recovery_helper.c b/ctdb/server/ctdb_recovery_helper.c
>index 4e4a986..d54c290 100644
>--- a/ctdb/server/ctdb_recovery_helper.c
>+++ b/ctdb/server/ctdb_recovery_helper.c
>@@ -140,6 +140,7 @@ static struct recdb_context *recdb_create(TALLOC_CTX *mem_ctx, uint32_t db_id,
> 	if (recdb->db == NULL) {
> 		talloc_free(recdb);
> 		LOG("failed to create recovery db %s\n", recdb->db_path);
>+		return NULL;
> 	}
> 
> 	recdb->persistent = persistent;
>-- 
>2.7.4
>

Flags:

martins: review+
sfrench: review+

Actions: View

Attachments on bug 12434: 12680 | 12681