Attachment 12628 Details for Bug 12405 – patch for 4.5

[patch] patch for 4.5

0001-s3-winbind-Do-not-return-NO_MEMORY-if-we-have-an-emp.patch (text/plain), 1.21 KB, created by Andreas Schneider on 2016-11-03 07:48:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2016-11-03 07:48:21 UTC

Size: 1.21 KB

patch

obsolete

>From 4198e52d3037216015dae5682f8c86b5a7d4e457 Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Wed, 2 Nov 2016 17:19:09 +0100
>Subject: [PATCH] s3-winbind: Do not return NO_MEMORY if we have an empty user
> list
>
>The domain child for the MACHINE ACCOUNT might fail with
>NT_STATUS_NO_MEMORY because an emtpy user list is returned.
>
>*pnum_info is already set to 0 at the beginngin so we should just
>declare victory here!
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=12405
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>
>(cherry picked from commit e714dc03e0ccf9ec17da6bacc1bcfcaea7518e22)
>---
> source3/winbindd/winbindd_rpc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/source3/winbindd/winbindd_rpc.c b/source3/winbindd/winbindd_rpc.c
>index 386396a..7b355ba 100644
>--- a/source3/winbindd/winbindd_rpc.c
>+++ b/source3/winbindd/winbindd_rpc.c
>@@ -88,6 +88,10 @@ NTSTATUS rpc_query_user_list(TALLOC_CTX *mem_ctx,
> 		num_dom_users = disp_info.info1.count;
> 
> 		num_info += num_dom_users;
>+		/* If there are no user to enumerate we're done */
>+		if (num_info == 0) {
>+			return NT_STATUS_OK;
>+		}
> 
> 		info = talloc_realloc(mem_ctx,
> 					    info,
>-- 
>2.10.1
>

Flags:

jra: review+

Actions: View

Attachments on bug 12405: 12628 | 12629